[
https://issues.apache.org/jira/browse/KAFKA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409931#comment-13409931
]
Joel Koshy commented on KAFKA-362:
----------------------------------
1 - ConsumerConfig:
a - Instead of NoneReplicaFetcherId, use FetchRequest.NonFollowerId (or
make it an alias of that)
b - So fetch.wait.time.ms and fetch.min.byte deprecate the existing
min.fetch.bytes and max.fetch.wait.ms configs? - ConsoleConsumer needs
to be updated (as it still uses the old ones). Actually, why rename
the existing configs?
2 - PartitionTopicInfo: Seems that enqueue does not need to return anything
now. Actually, it's unclear: the comment above processPartitionData in
AbstractFetcherManager says that it returns the new fetch offset but the
implementation does not return anything.
3 - AbstractFetcherThread: Line 77: is the check on isRunning necessary?
4 - AbstractFetcherManager: rename numReplicaFetchers to numFetchers.
5 - ConsumerFetcherManager: just a thought (I have not looked carefully
enough for feasibility): for noLeaderPartitionSet - would it be possible
to use a SynchronousQueue[Seq[(String, Int)] instead? That way, you may be
able to get rid of the refreshLeaderBackOff, and the lock and its
associated condition (although you would need to use an atomic reference
for the partitionMap).
- completes -> completed
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala:
info("shutdown completes")
core/src/main/scala/kafka/server/ReplicaFetcherManager.scala: info("shutdown
completes")
> ZookeeperConsumerConnector needs to connect to new leader after leadership
> change
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-362
> URL: https://issues.apache.org/jira/browse/KAFKA-362
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.8
>
> Attachments: kafka-362_v1.patch, kafka-362_v2.patch
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
> Currently, if the leader of a partition changes, the fetcher in
> ZookeeperConsumerConnector won't switch to the new leader automatically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
