[ 
https://issues.apache.org/jira/browse/KAFKA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Fung updated KAFKA-306:
----------------------------

    Attachment: kafka-306-v9.patch

Thanks Jun for reviewing. Your suggestion are made in kafka-306-v9.patch.

The changes are:
91. numThreadsOpt is defaulted to 1 and the 'if' block is removed

92. The following block is actually not necessary and it's now removed:
          if (config.seqIdMode) { 
              producer.send(new ProducerData[Message,Message](config.topic, 
null, message)) 
            } 
                
> broker failure system test broken on replication branch
> -------------------------------------------------------
>
>                 Key: KAFKA-306
>                 URL: https://issues.apache.org/jira/browse/KAFKA-306
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: John Fung
>              Labels: replication
>         Attachments: kafka-306-v1.patch, kafka-306-v2.patch, 
> kafka-306-v3.patch, kafka-306-v4.patch, kafka-306-v5.patch, 
> kafka-306-v6.patch, kafka-306-v7.patch, kafka-306-v8.patch, kafka-306-v9.patch
>
>
> The system test in system_test/broker_failure is broken on the replication 
> branch. This test is a pretty useful failure injection test that exercises 
> the consumer rebalancing feature, various replication features like leader 
> election. It will be good to have this test fixed as well as run on every 
> checkin to the replication branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to