[
https://issues.apache.org/jira/browse/KAFKA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422562#comment-13422562
]
Neha Narkhede commented on KAFKA-351:
-------------------------------------
>From KAFKA-405 -
ReplicaManager:
This class has a very odd public interface. Instead of managing replicas it has
a bunch of passive calls--addLocalReplica(), addRemoteReplica(), etc. Who calls
these? KafkaServer seems to have its own wrapper for these. Then it passes
these methods on as arguments to KafkaZookeeper. Does this make sense? I think
it would be good if ReplicaManager handled replica management, even if that
means it depends on zookeeper.
> Refactor some new components introduced for replication
> --------------------------------------------------------
>
> Key: KAFKA-351
> URL: https://issues.apache.org/jira/browse/KAFKA-351
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
>
> Jay had some good refactoring suggestions as part of the review for KAFKA-46.
> I'd like to file this umbrella JIRA with individual sub tasks to cover those
> suggestions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
