[
https://issues.apache.org/jira/browse/KAFKA-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425180#comment-13425180
]
Jun Rao commented on KAFKA-384:
-------------------------------
Thanks for the patch. It looks good. Just 1 comment:
1. AsyncProducerTest.testQueueTimeExpired(): This is an existing issue, but
probably can be fixed in this patch too. It seems that we should do
producerSendThread.shutdown after EasyMock.verify(mockHandler). Shutdown always
sends all remaining messages in the buffer. If we call shutdown before verify,
it's not clear if the send was triggered by timeout or shutdown.
> Fix intermittent test failures and remove unnecessary sleeps
> ------------------------------------------------------------
>
> Key: KAFKA-384
> URL: https://issues.apache.org/jira/browse/KAFKA-384
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Neha Narkhede
> Attachments: kafka-384-v1.patch
>
>
> Seeing intermittent failures in 0.8 unit tests. Also, many sleeps can be
> removed (with producer acks in place) and I think MockTime isn't used in some
> places where it should.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
