[
https://issues.apache.org/jira/browse/KAFKA-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430770#comment-13430770
]
Neha Narkhede edited comment on KAFKA-440 at 8/8/12 6:38 PM:
-------------------------------------------------------------
Thanks for the patch, John! Here are few review comments -
1. Let's move the framework under system_test instead of reg_test.
2. Use svn propset to set executable properties on the scripts.
http://lexfridman.com/blogs/research/2011/02/21/executable-files-in-svn/
3. Testcase 2
3.1 The testcase config file has /tmp/jfung as the log directory path. Let's
change it to remove jfung from the path.
3.2 Add some more details to the description in testcase_2. (Similar to the
description you have for testcase_1). So, to understand one testcase I
shouldn't have to understand another testcase.
3.3 In "server_to_bounce", I would just expect to say "leader". Right now it
says source, target and mirror_maker which are unrelated to replication.
3.4. What does "partition" stand for ? Do you mean "num_partitions"
4. Add README to reg_test/system_test that describes the new framework and also
set of instructions that people can follow to add new testcases.
5. It also probably makes sense to add a jmx_port config option to
reg_test/cluster_config.json. Right now, the JMX_PORT is disabled, so there is
no way to collect monitoring data from the various entities.
was (Author: nehanarkhede):
Thanks for the patch, John! Here are few review comments -
1. Let's move the framework under system_test instead of reg_test.
2. Use svn propset to set executable properties on the scripts.
http://lexfridman.com/blogs/research/2011/02/21/executable-files-in-svn/
3. Testcase 2
3.1 The testcase config file has /tmp/jfung as the log directory path. Let's
change it to remove jfung from the path.
3.2 Add some more details to the description in testcase_2. (Similar to the
description you have for testcase_1). So, to understand one testcase I
shouldn't have to understand another testcase.
3.3 In "server_to_bounce", I would just expect to say "leader". Right now it
says source, target and mirror_maker which are unrelated to replication.
3.4. What does "partition" stand for ? Do you mean "num_partitions"
4. Add README to reg_test/system_test that describes the new framework and also
set of instructions that people can follow to add new testcases.
> Create a regression test framework for distributed environment testing
> ----------------------------------------------------------------------
>
> Key: KAFKA-440
> URL: https://issues.apache.org/jira/browse/KAFKA-440
> Project: Kafka
> Issue Type: Task
> Reporter: John Fung
> Assignee: John Fung
> Attachments: kafka-440-v1.patch
>
>
> Initial requirements:
> 1. The whole test framework is preferably coded in Python (a common scripting
> language which has well supported features)
> 2. Test framework driver should be generic (distributed environment can be
> local host)
> 3. Test framework related configurations are defined in JSON format
> 4. Test environment, suite, case definitions may be defined in the following
> levels:
> 4-a entity_id is used as a key for looking up related config from different
> levels
> 4-b Cluster level defines: entity_id, hostname, kafka_home, java_home, ...
> 4-c Test suite / case level defines:
> 4-c-1 zookeeper: entity_id, clientPort, dataDir, log_filename,
> config_filename
> 4-c-2 broker: entity_id, port, log.file.size, log.dir, log_filename,
> config_filename
> 4-c-3 producer: entity_id, topic, threads, compression-codec,
> message-size, log_filename, config_filename
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
