[ 
https://issues.apache.org/jira/browse/KAFKA-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445349#comment-13445349
 ] 

Neha Narkhede commented on KAFKA-483:
-------------------------------------

Thanks for the patch. Overall, it looks great !

A couple of minor comments -

1. Let's print the leader election latency at the end of the test run. Right 
now, it's getting lost amongst the other log messages.
2. How about printing the full path to the java home that the script picks up 
by default ? Right now, it strips off bin/java, so it is a little confusing to 
read.

Thanks for fixing the matplotlib usage to remove the dependency on Xserver.
                
> The system test is preferred to run out of the box without the need to update 
> cluster_config.json
> -------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-483
>                 URL: https://issues.apache.org/jira/browse/KAFKA-483
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-483-v1.patch, kafka-483-v2.patch, 
> kafka-483-v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to