[ 
https://issues.apache.org/jira/browse/KAFKA-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451503#comment-13451503
 ] 

Eli Reisman commented on KAFKA-367:
-----------------------------------

I still need to add console opts for encoding and write these new constructors 
into the producer and consumer stuff, but the way I have the patch now I 
believe the properties calls have hardcoded defaults to "UTF-8" so acutally I 
do think even the no-arg constructors would be safe with this in the case where 
no character encoding option is chosen. Am I wrong about that? 

Anyway there's more to do here regardless, will get to it and post something 
ASAP

                
> StringEncoder/StringDecoder use platform default character set
> --------------------------------------------------------------
>
>                 Key: KAFKA-367
>                 URL: https://issues.apache.org/jira/browse/KAFKA-367
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Eli Reisman
>              Labels: newbie
>         Attachments: KAFKA-367-1.patch, KAFKA-367-2.patch, KAFKA-367-3.patch, 
> KAFKA-367-3.patch
>
>
> StringEncoder and StringDecoder take the platform default character set. This 
> is bad since the messages they produce are sent off that machine. We should
> -- add a new required argument to these that adds the character set and 
> default to UTF-8 rather than the machine setting
> -- add a commandline parameter for the console-* tools to let you specify the 
> correct encoding.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to