[
https://issues.apache.org/jira/browse/KAFKA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454305#comment-13454305
]
Joel Koshy commented on KAFKA-203:
----------------------------------
+1 on v2.
The following are all minor comments.
2.1 - For the TODO in Partition.scala, can you add a comment in the jira
where it will be addressed (or create a separate jira) so we don't lose
track of it.
2.2 - SimpleConsumer.scala: FetchRequestRateAndTimeMs ->
FetchRequestRateAndDurationMs. Similar edits in FileMessageSet.scala for
LogFlushRateAndTimeMs; SyncProducer.scala for
ProduceRequestRateAndTimeMs
2.3 - ProducerTopicStat.scala: resents -> resends
2.4 - DefaultEventHandler.scala:
a - val isSync = "sync".equals(config.producerType)
b - So exceptions are no longer thrown for async producers on a
serialization error. This will have an impact on KAFKA-496. Can you
add a comment there after check-in?
2.5 - ReplicaManager: the meter name is inconsistent with the convention
used elsewhere.
> Improve Kafka internal metrics
> ------------------------------
>
> Key: KAFKA-203
> URL: https://issues.apache.org/jira/browse/KAFKA-203
> Project: Kafka
> Issue Type: New Feature
> Components: core
> Affects Versions: 0.8
> Reporter: Jay Kreps
> Assignee: Jun Rao
> Labels: tools
> Attachments: kafka-203_v1.patch, kafka-203_v2.patch
>
>
> Currently metrics in kafka are using old-school JMX directly. This makes
> adding metrics a pain. It would be good to do one of the following:
> 1. Convert to Coda Hale's metrics package
> (https://github.com/codahale/metrics)
> 2. Write a simple metrics package
> The new metrics package should make metrics easier to add and work with and
> package up the common logic of keeping windowed gauges, histograms, counters,
> etc. JMX should be just one output of this.
> The advantage of the Coda Hale package is that it exists so we don't need to
> write it. The downsides are (1) introduces another client dependency which
> causes conflicts, and (2) seems a bit heavy on design. The good news is that
> the metrics-core package doesn't seem to bring in a lot of dependencies which
> is nice, though the scala wrapper seems to want scala 2.9. I am also a little
> skeptical of the approach for histograms--it does sampling instead of
> bucketing though that may be okay.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
