[
https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456710#comment-13456710
]
Jun Rao commented on KAFKA-391:
-------------------------------
Thanks for patch v4. +1 Could you fix the following minor issues before
checking in?
41. scala version of FetchResponse: We throw an exception in errorCode if the
map key doesn't exist. To be consistent, we should do the same for messageSet
and highWatermark.
42. PartitionStatus: Since this is a case class, there is no need to define
requiredOffset as val.
43. DefaultEventHandler.serialize(): This is not introduced in this patch, but
could you change error("Error serializing message " + t) to error("Error
serializing message ", t)
> Producer request and response classes should use maps
> -----------------------------------------------------
>
> Key: KAFKA-391
> URL: https://issues.apache.org/jira/browse/KAFKA-391
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-391-draft-r1374069.patch, KAFKA-391-v2.patch,
> KAFKA-391-v3.patch, KAFKA-391-v4.patch
>
>
> Producer response contains two arrays of error codes and offsets - the
> ordering in these arrays correspond to the flattened ordering of the request
> arrays.
> It would be better to switch to maps in the request and response as this
> would make the code clearer and more efficient (right now, linear scans are
> used in handling producer acks).
> We can probably do the same in the fetch request/response.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
