[
https://issues.apache.org/jira/browse/KAFKA-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457138#comment-13457138
]
Jun Rao commented on KAFKA-500:
-------------------------------
Thanks for patch v1. Some comments:
1. javaapi.SyncProducer returns a list of the scala version of TopicMetadata.
We need to create a java version of TopicMetadata and PartitionMetadata to hide
things like Seq and Option. Also, since we only return TopicMetadata to the
java client. There is probably no need for a java version of
TopicMetadataResponse.
2. In kafka-391, we are getting rid of the java version of SyncProducer since
it's no longer a public api (java users should use Producer instead). So, there
is no need to put the getMetadata api in javaapi.SyncProducer. However, we
should include it in javaapi.SimpleConsumer, which remains a public api.
3. TopicMetadataResponseTest: The test of the java version of the response can
probably be made simpler. We just need to make sure that we can convert from a
scala response to a java response correctly.
4. Patch doesn't apply cleanly, likely due to renaming class names.
> javaapi support for getTopoicMetaData
> -------------------------------------
>
> Key: KAFKA-500
> URL: https://issues.apache.org/jira/browse/KAFKA-500
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: bugs
> Fix For: 0.8
>
> Attachments: kafka-500-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> TopicMetaRequest and TopicMetaResponse use scala Seq and Option. We need a
> version so that java applications can use more easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
