[ 
https://issues.apache.org/jira/browse/KAFKA-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459816#comment-13459816
 ] 

Jun Rao commented on KAFKA-344:
-------------------------------

Thanks for patch v1. Some comments.

1. main: 
1.1 Add some comments at the beginning that describe how the tool is built.
1.2 print out an error message on exception in addition to the stack trace. 
1.3 Most required command line options are not enforced, e.g. consumer.config, 
zkclient.01.jar, kafka.07.jar. Also, at least one of the whilelist/blacklist 
needs to be specified.
1.4 There is a weird regex to subscribe to all topics. Could you add that in 
the description of whitelist? I can't seem that get wildcard working. Tried 
things like --whilelist "test*". However, it seems to only pick up topic 
"test", but not "test1".

2. MigrationThread: 
2.1 The following line should be written to log4j under DEBUG level, instead of 
stdout. Also, since message is binary, printing out the content is useless. We 
can probably just output the topic name and the message length.
          System.out.println("send 08 message: " + bytes.toString());
2.2 Normally, we should never finish the while loop. However, it would be 
useful to add an info level logging to indicate if the loop is finished.
2.3 IterableNextMethod is not used.


                
> migration tool from 0.7 to 0.8
> ------------------------------
>
>                 Key: KAFKA-344
>                 URL: https://issues.apache.org/jira/browse/KAFKA-344
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Yang Ye
>            Priority: Blocker
>              Labels: tools
>             Fix For: 0.8
>
>         Attachments: kafka-0.7.0.jar, kafka_07_producer_performance.patch, 
> kafka_344_draft.patch, kafka_344_v1.diff, zkclient-0.1.jar
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Since 0.8 is a non-backward compatible release, we need a migration tool. One 
> way to do that is to have a tool that can mirror data from an 0.7 Kafka 
> cluster into an 0.8 Kafka cluster. Once the mirror is set up, we can then 
> first migrate the consumers to the 0.8 cluster, followed by the producers. 
> After that, we can decommission the 0.7 cluster. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to