[
https://issues.apache.org/jira/browse/KAFKA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462985#comment-13462985
]
Jun Rao commented on KAFKA-473:
-------------------------------
Thanks for patch v2. A couple of more comments:
20. What does the following line in ZookeeperConsumerConnector.rebalance() do?
(topic, partitions)
21. ProducerPool.createSyncProducer(configOpt: Option[ProducerConfig]): This
one always expects a ProducerConfig. So, we shouldn't use Option. Also, this
method seems not to be used anywhere. We can just remove it.
> Use getMetadata Api in ZookeeperConsumerConnector
> -------------------------------------------------
>
> Key: KAFKA-473
> URL: https://issues.apache.org/jira/browse/KAFKA-473
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: newbie, optimization
> Fix For: 0.8
>
> Attachments: kafka_473_v1.diff, kafka_473_v2.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Currently, ZookeeperConsumerConnector gets topic metadata from ZK directly.
> It's better to use the getMetadata Api since it's batched. This is especially
> helpful if the consumer client is in a different data center.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
