Yes, the release code should be a snapshot of our svn. So, it makes sense to remove the client dir, change LICENSE and NOTICE first, and then cut a release. Before we do that, we can create a branch so that people can retrieve the old client code easier.
Thanks, Jun On Wed, Sep 26, 2012 at 7:59 AM, Joe Stein <crypt...@gmail.com> wrote: > I removed it in the release yup but it is still in the repository. > > I was thinking we could branch the client directory so it is somewhere > (branches/legacy_client_lib) but then remove it from 0.7.2 branch, 0.8 > branch and trunk and then apply the LICENSE and NOTICE change > https://issues.apache.org/jira/browse/KAFKA-533 > > I think people checking out the code would see this to be cleaner comparing > to what is in a release and matching things up to what the NOTICE and > LICENSE file is saying (not just in the release but in the repository) > > On Wed, Sep 26, 2012 at 10:42 AM, Jun Rao <jun...@gmail.com> wrote: > > > I thought the client dir is already removed. I can't find it in the > release > > tar ball. > > > > Thanks, > > > > Jun > > > > On Tue, Sep 25, 2012 at 9:33 PM, Joe Stein <crypt...@gmail.com> wrote: > > > > > good point > > > > > > should we remove the client dir from the repo then? we don't want to > > make > > > our packaged release stray to far from our repo, right? > > > > > > On Wed, Sep 26, 2012 at 12:26 AM, Jun Rao <jun...@gmail.com> wrote: > > > > > > > It seems that we don't need nunit in both LICENSE and NOTICE since we > > > have > > > > removed the csharp client. > > > > > > > > Thanks, > > > > > > > > Jun > > > > > > > > On Mon, Sep 24, 2012 at 11:46 PM, Joe Stein <crypt...@gmail.com> > > wrote: > > > > > > > > > Hello, > > > > > > > > > > This is the third candidate for the third incubator release for > > Apache > > > > > Kafka, version 0.7.2-incubating. > > > > > > > > > > This release fixes the following issues > > > > > > > > > > > > > > > > > > > > http://people.apache.org/~joestein/kafka-0.7.2-incubating-candidate-3/RELEASE-NOTES.html > > > > > > > > > > RC2 fixed RC1 with a change in packaging to remove the ./clients/ > > > > > directory. An issue was introduced then during packaging that > messed > > > up > > > > > the DISCLAIMER file, RC3 fixes that. > > > > > > > > > > *** Please download, test and vote by Friday September, 28th, 12pm > > PDT > > > > *** > > > > > > > > > > Release artifacts to be voted upon: > > > > > > > > > https://people.apache.org/~joestein/kafka-0.7.2-incubating-candidate-3/ > > > > > > > > > > The tag (off the 0.7.2 branch) for release artifacts: > > > > > > > > > > > > > > > > > > > > https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.2-incubating-candidate-3 > > > > > > > > > > Kafka's KEYS file containing PGP keys we use to sign the release: > > > > > https://svn.apache.org/repos/asf/incubator/kafka/KEYS > > > > > > > > > > -- > > > > > > > > > > /* > > > > > Joe Stein > > > > > http://www.linkedin.com/in/charmalloc > > > > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > > > > > */ > > > > > > > > > > > > > > > > > > > > > -- > > > > > > /* > > > Joe Stein > > > http://www.linkedin.com/in/charmalloc > > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > > > */ > > > > > > > > > -- > > /* > Joe Stein > http://www.linkedin.com/in/charmalloc > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > */ >
