[ 
https://issues.apache.org/jira/browse/KAFKA-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468142#comment-13468142
 ] 

Joel Koshy commented on KAFKA-363:
----------------------------------

Thanks for the patch, David.

1. Can we make the name match case insensitive? i.e., just 
name.toLowerCase.match
2. Any particular reason to change the config name to compression.name? I think 
compression.codec looks better.
3. Can you make it backward compatible? i.e., allow both int and string in 
ProducerConfig. (Also, there are other usages of compression.codec - e.g., in 
system tests and contrib/hadoop* that still use the int).

                
> Replace numerical compression codes in config with something human readable
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-363
>                 URL: https://issues.apache.org/jira/browse/KAFKA-363
>             Project: Kafka
>          Issue Type: Bug
>          Components: config
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>            Priority: Minor
>              Labels: newbie
>         Attachments: KAFKA-363.patch
>
>
> Currently we have compression codes like 1 or 2, which is pretty unintuitive. 
> What does 1 mean?
> We should replace these with human-readable codes like "snappy", "gzip", or 
> "none" and change the documentation. We can continue to support the existing 
> integer codes in addition for backwards compatibility with existing 
> configurations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to