[
https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471733#comment-13471733
]
Jun Rao commented on KAFKA-42:
------------------------------
Thanks for patch v3. Looks good to me overall. Just one comment:
20.3 The problem is that reassignPartitions() uses
updatePartitionReassignmentData, which in turn uses updatePersistentPath.
updatePersistentPath won't throw an exception if a node already exists. So,
what could happen is that 2 admin commands are issued at the same time. Both
pass the existence test of the ZK path. One command writes its data in the
reassignment path first. The other one then overwrites it. Now, both commands
appear to have completed successfully. Using ZkUtils.createPersistentPath()
instead of updatePersistentPath() would prevent this since the former throws an
exception if the path already exists.
> Support rebalancing the partitions with replication
> ---------------------------------------------------
>
> Key: KAFKA-42
> URL: https://issues.apache.org/jira/browse/KAFKA-42
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: features
> Fix For: 0.8
>
> Attachments: kafka-42-v1.patch, kafka-42-v2.patch, kafka-42-v3.patch
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> As new brokers are added, we need to support moving partition replicas from
> one set of brokers to another, online.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
