[
https://issues.apache.org/jira/browse/KAFKA-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472133#comment-13472133
]
Jun Rao commented on KAFKA-551:
-------------------------------
Thanks for the patch. Looks good. Just one comment.
1. OffsetIndex.truncateTo(): If there is an index entry that equals to the
target offset, shouldn't we delete that index entry too? TruncateTo will make
target offset the offset for the next append and there shouldn't be an index
entry for offset no available yet.
> Log.truncateTo() may need to trucate immutable log segment
> ----------------------------------------------------------
>
> Key: KAFKA-551
> URL: https://issues.apache.org/jira/browse/KAFKA-551
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Priority: Blocker
> Labels: bugs
> Attachments: KAFKA-551.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In makeFollower, we need to first truncate the local log to high watermark.
> It's possible that we need to truncate into segments before the last one. The
> problem is that all segments except the last one are immutable. So the
> truncation will fail which prevents the replica fetcher from being started.
> One solution is to reopen the segment as mutable during truncation, if it's
> not mutable already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
