[
https://issues.apache.org/jira/browse/KAFKA-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475110#comment-13475110
]
Neha Narkhede commented on KAFKA-537:
-------------------------------------
Until you rebase, I reviewed v2 on an older svn review. Here are some review
comments -
1. ConsumerConfig
1. Every config value has a comment explaining its purpose. Please can you add
this for the new config "clientid" ?
2. I wonder if specifying a default value of empty string is useful ? Maybe
groupid makes more sense or no default at all.
2. FetchRequest
2.1 According to coding convention, every constant is in camel case with first
letter capital. Please can you change replicaFetcherClientId to
ReplicaFetcherClientId ?
3. KafkaApis
3.1 Fix the typo - private def appendToLocalLog(producerRquest:
ProducerRequest): Iterable[ProduceResult] = {
3.2 Let's fix the requestLogger to print the clientId. This allows us to have a
meaningful access log for Kafka where requests can be traced back to client ids.
4. ReplicaFetcherThread
4.1 Every replica's clientId is "replica fetcher". I wonder if we can add the
replica's id/host/both to the replica's client id. This will allow us to
differentiate amongst requests from the various replicas at the leader.
5. FetchRequestBuilder
Right now, we are depending on the user to not re-create the
FetchRequestBuilder each time. How about making the builder a singleton so that
is not possible ? That way, we can guarantee that it is initialized to 0 only
one per client.
> expose clientId and correlationId in ConsumerConfig
> ---------------------------------------------------
>
> Key: KAFKA-537
> URL: https://issues.apache.org/jira/browse/KAFKA-537
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Yang Ye
> Labels: bugs, newbie
> Fix For: 0.8
>
> Attachments: kafka_537_v1.diff, kafka_537_v2.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We need to expose clientId and correlationId in ConsumerConfig and use it
> properly in AbstractFetcherThread. For follower fetchers, we should set the
> clientId to a special string, something list "follower".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
