[
https://issues.apache.org/jira/browse/KAFKA-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475435#comment-13475435
]
Neha Narkhede edited comment on KAFKA-43 at 10/12/12 11:34 PM:
---------------------------------------------------------------
Thanks for the review, Jun and Joel ! Here is a follow up patch to address your
review suggestions -
Joel's review
>> - Would be good to have a short --help string for all the admin tools.
That is provided by the joptparser when you invoke it without any parameters
KafkaController:
>> - Instead of nulls in the controller context, can we switch to Set.empty? I
>> can try that in KAFKA-340 as well.
Would like to do that in a follow up cleanup patch. If you get to it before,
that's fine as well.
>> - Would be clearer to rename removePartitionsFromPreferredReplicaElection to
>> maybeRemove...
Didn't rename this since it *always* removes the partitions
Rest of the comments are addressed
Jun's review
That's a great point. Changed the tool to default to all partitions.
Also, found a bug in the PreferredReplicaPartitionLeaderSelector where it
didn't check if the preferred replica was in the isr or not. Fixed that.
was (Author: nehanarkhede):
Thanks for the review, Jun and Joel ! Here is a follow up patch to address
your review suggestions -
>> - Would be good to have a short --help string for all the admin tools.
That is provided by the joptparser when you invoke it without any parameters
KafkaController:
>> - Instead of nulls in the controller context, can we switch to Set.empty? I
>> can try that in KAFKA-340 as well.
Would like to do that in a follow up cleanup patch. If you get to it before,
that's fine as well.
>> - Would be clearer to rename removePartitionsFromPreferredReplicaElection to
>> maybeRemove...
Didn't rename this since it *always* removes the partitions
Rest of the comments are addressed
> Rebalance to preferred broke with intra-cluster replication support
> -------------------------------------------------------------------
>
> Key: KAFKA-43
> URL: https://issues.apache.org/jira/browse/KAFKA-43
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: features
> Fix For: 0.8
>
> Attachments: kafka-43-v1.patch, kafka-43-v2.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> We need to allow the leader to be moved to the preferred broker, for better
> load balancing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
