[
https://issues.apache.org/jira/browse/KAFKA-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475461#comment-13475461
]
Jun Rao commented on KAFKA-43:
------------------------------
Thanks for patch v2.
Thanks for patch v2. Just some minor comments. Once addressed, the patch can be
checked in without another review.
20. AdminTest:
20.1 testBasicPreferredReplicaElection(): remove the println statement
20.2 remove unused imports
21. KafkaController.removePartitionsFromPreferredReplicaElection(): If we can't
move the leader, we should probably log it as warning instead of error.
22. PartitionLeaderSelector.PreferredReplicaPartitionLeaderSelector(): Instead
of using match/case, it seems it's simpler if we write it as if/else. If the
preferred replica is in isr and is live, then we move the leader to the
preferred replica. Otherwise, we just throw an exception.
23. TestUtils.readFileIntoString(): not used.
> Rebalance to preferred broke with intra-cluster replication support
> -------------------------------------------------------------------
>
> Key: KAFKA-43
> URL: https://issues.apache.org/jira/browse/KAFKA-43
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: features
> Fix For: 0.8
>
> Attachments: kafka-43-v1.patch, kafka-43-v2.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> We need to allow the leader to be moved to the preferred broker, for better
> load balancing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
