[ 
https://issues.apache.org/jira/browse/KAFKA-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482481#comment-13482481
 ] 

Jun Rao commented on KAFKA-571:
-------------------------------

Thanks for patch v2. Looks good. One more comment.

20. In migration_tool_testsuite/config, some of the configs are for 0.7 and 
some others are for 0.8. Could we rename them with the associated version #? 
Note that some of the configs have changed btw 0.7 and 0.8.

Could you also rebase and include the SimpleConsumerShell change in the final 
patch?
                
> Add more test cases to System Test
> ----------------------------------
>
>                 Key: KAFKA-571
>                 URL: https://issues.apache.org/jira/browse/KAFKA-571
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: John Fung
>            Assignee: John Fung
>             Fix For: 0.8
>
>         Attachments: kafka-0.7.0.jar, kafka-571-SimpleConsumerShell.patch, 
> kafka-571-v1.patch, kafka-571-v2.patch, kafka-perf-0.7.0.jar, zkclient-0.1.jar
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to