[
https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483415#comment-13483415
]
Neha Narkhede commented on KAFKA-267:
-------------------------------------
Thanks for patch v5, we are pretty close to checking this in. A few more review
comments -
1. Fix the description of the topics argument, it should just say "produce to".
Let's remove the consume from. Also, if it is a csv list, let's add that to the
description as well
2. Fix the description of batch-size. Right now, it just says "size". Same for
threads, it just says "count"
3. Let's describe the supported compression codecs in the description for
compression-codec.
4. I think it is valuable to default to async. That is the most common
production usage, I doubt we will frequently test one-message-at-a-time
5. Should message-send-gap be renamed to message-send-gap-ms ?
6. Now that we have metrics csv reporter, will we use ProducerPerformance to
calculate the producer throughput in MB/s, messages/sec at all ? I guess we can
just enable csv reporting and rely on our metrics to measure throughput/latency
correctly. In that case, we don't need to compute the various metrics and also
can get rid of the println and showDetailedStats parameter. With this change,
we can view ProducerPerformance like a workload generator only. Not sure if I'm
missing something here though.
7. generateProducerData is a bit unreadable. Recommend you separately compute
the messageId and messageSize and pass it into generateMessageWithSeqId
> Enhance ProducerPerformance to generate unique random Long value for payload
> ----------------------------------------------------------------------------
>
> Key: KAFKA-267
> URL: https://issues.apache.org/jira/browse/KAFKA-267
> Project: Kafka
> Issue Type: Improvement
> Reporter: John Fung
> Assignee: Yang Ye
> Attachments: kafka-267-v1.patch, kafka-267-v2.patch,
> kafka-267-v3.patch, kafka-267-v4.patch, kafka-267-v5.patch
>
>
> This is achieved by:
> 1. Adding a new class UniqueRandom to shuffle a range of numbers.
> 2. An optional new argument "start-index" is added to specify the starting
> number of the range to be shuffled. If this argument is omitted, it is
> defaulted to 1. So it is backward compatible with the argument options.
> 3. The ending number of the range is the starting number + number of messages
> - 1.
> Other ProducerPerformance advancement:
> 1. producing to multiple topics
> 2. supporting multiple instances of producer performance ( and distinguishes
> them)
> 3. allowing waiting some time after sending a request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
