[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489260#comment-13489260 ]
Jun Rao commented on KAFKA-593: ------------------------------- Thanks for the patch. A couple of comments: 1. Log.rollToOffset(): We just need to verify that the starting offset of the last segment doesn't equal to the new offset. 2. OffsetIndex: When loading the log segment on broker startup, it is possible to have a segment with empty data and empty index. So, we will hit the same issue of rolling a segment with a duplicated name. We probably should extend the index size to max index size in the constructor of OffsetIndex. > Empty log index file created when it shouldn't be empty > ------------------------------------------------------- > > Key: KAFKA-593 > URL: https://issues.apache.org/jira/browse/KAFKA-593 > Project: Kafka > Issue Type: Bug > Reporter: Yang Ye > Attachments: kafka_583_zk_kafka_data.tar.gz, kafka_593_v1.diff > > > We have met empty index file during system test when it shouldn't be empty. > In this case, there're around 100 messages in each segment, each of size > around 100 bytes, given the "logIndexIntervalBytes" 4096, there should be at > least 2 log index entries, but we see empty index file. The kafka and > zookeeper logs are attached > [yye@yye-ld kafka_server_3_logs]$ cd test_1-2/ > [yye@yye-ld test_1-2]$ ls -l > total 84 > -rw-r--r-- 1 yye eng 8 Oct 29 15:22 00000000000000000000.index > -rw-r--r-- 1 yye eng 10248 Oct 29 15:22 00000000000000000000.log > -rw-r--r-- 1 yye eng 8 Oct 29 15:22 00000000000000000100.index > -rw-r--r-- 1 yye eng 10296 Oct 29 15:22 00000000000000000100.log > -rw-r--r-- 1 yye eng 0 Oct 29 15:23 00000000000000000200.index > -rw-r--r-- 1 yye eng 10293 Oct 29 15:23 00000000000000000200.log > -rw-r--r-- 1 yye eng 0 Oct 29 15:23 00000000000000000300.index > -rw-r--r-- 1 yye eng 10274 Oct 29 15:23 00000000000000000300.log > -rw-r--r-- 1 yye eng 0 Oct 29 15:23 00000000000000000399.index > -rw-r--r-- 1 yye eng 10276 Oct 29 15:23 00000000000000000399.log > -rw-r--r-- 1 yye eng 0 Oct 29 15:23 00000000000000000498.index > -rw-r--r-- 1 yye eng 10256 Oct 29 15:23 00000000000000000498.log > -rw-r--r-- 1 yye eng 10485760 Oct 29 15:23 00000000000000000596.index > -rw-r--r-- 1 yye eng 3564 Oct 29 15:23 00000000000000000596.log -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira