[
https://issues.apache.org/jira/browse/KAFKA-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489266#comment-13489266
]
Jun Rao commented on KAFKA-596:
-------------------------------
Thanks for the patch. A couple of comments:
1. Log.maybeRoll(): Are the following lines needed since we are not creating a
new segment?
if (segment.messageSet.sizeInBytes == 0)
segment.firstAppendTime = None
2. Log.markedDeletedWhile(): Is the following line needed since we are not
creating a new segment?
view(numToDelete - 1).firstAppendTime = None
> LogSegment.firstAppendTime not reset after truncate to
> ------------------------------------------------------
>
> Key: KAFKA-596
> URL: https://issues.apache.org/jira/browse/KAFKA-596
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: bugs
> Attachments: kafka-596.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently, we don't reset LogSegment.firstAppendTime after the segment is
> truncated. What can happen is that we truncate the segment to size 0 and on
> next append, a new log segment with the same starting offset is rolled
> because the time-based rolling is triggered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
