[
https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499860#comment-13499860
]
Jun Rao commented on KAFKA-532:
-------------------------------
Thanks for patch v5. Looks good. Just a couple of minor comments.
50. LeaderAndIsrResponse and StopReplicaResponse: Currently, for all types of
response, we have moved to the model that there is no global error code at the
response level. Instead, if a request can't be processed for any partition, we
just set the same error code for each partition in the response. This achieves
the same effect, but makes the handling of the response easier. One just has to
deal with the error code per partition.
51. Are the changes in test/resources/log4j.properties intended?
> Multiple controllers can co-exist during soft failures
> ------------------------------------------------------
>
> Key: KAFKA-532
> URL: https://issues.apache.org/jira/browse/KAFKA-532
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: bugs
> Attachments: kafka-532-v1.patch, kafka-532-v2.patch,
> kafka-532-v3.patch, kafka-532-v4.patch, kafka-532-v5.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> If the current controller experiences an intermittent soft failure (GC pause)
> in the middle of leader election or partition reassignment, a new controller
> might get elected and start communicating new state change decisions to the
> brokers. After recovering from the soft failure, the old controller might
> continue sending some stale state change decisions to the brokers, resulting
> in unexpected failures. We need to introduce a controller generation id that
> increments with controller election. The brokers should reject any state
> change requests by a controller with an older generation id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
