On 09 Apr 2002 19:51:52 -0700,
Thomas Duffy <[EMAIL PROTECTED]> wrote:
>It was still failing for me after deleting the aic7xxx obj directory,
>running make mrproper, etc. The USER command was not being run for
>aic7xxx_seq.h, however it was running for aic7xxx_reg.h, so I figured it
>was not getting the dependencies correct. This patch made it work for
>me. (cause it really is aic7xxx_core.o that is depends on
>aic7xxx_seq.h)
Ahah! because aic7xxx 2.4.18 is breakin the kbuild rules. It has
aic7xxx.c and a conglomerate object called aic7xxx.o, you cannot do
that in make. I added aic7xxx_core.c as a wrapper to use the correct
names, aic7xxx_core.c includes aic7xxx.c. So grep aic7xxx_seq.h finds
aic7xxx.c but we build from aic7xxx_core.c.
By coincidence, make -j4 hid this problem, single threaded make hit it.
Fortunately the aic7xxx maintainer is starting to see the light, in
2.4.19-pre*, aic7xxx.c was renamed to aic7xxx_core.c so kbuild no
longer requires a wrapper. Now if I can just stop him shipping files
and overwriting them at run time ...
Add after kbuild-2.5-common-2.4.18-2.
-- drivers/scsi/aic7xxx/Makefile.in.orig Wed Apr 10 13:49:26 2002
+++ drivers/scsi/aic7xxx/Makefile.in Wed Apr 10 13:42:36 2002
@@ -27,9 +27,10 @@
select(CONFIG_SCSI_AIC7XXX aic7xxx.o)
-# Only aic7xxx.c includes aic7xxx_seq.h.
+# Only aic7xxx.c includes aic7xxx_seq.h. Because of the broken naming
+# standards, aic7xxx.c is not used directly, it is included via aic7xxx_core.c.
-$(objfile aic7xxx.o): $(objfile aic7xxx_seq.h)
+$(objfile aic7xxx_core.o): $(objfile aic7xxx_seq.h)
# aic7xxx_reg.h is messy. It is included by aic7xxx.h which is included by
# aic7xxx_osm.h which is included by several .c files. Play safe and make all
@@ -56,12 +57,12 @@
else
ifneq ($(KBUILD_SRCTREE_000),$(KBUILD_OBJTREE))
user_command(aic7xxx_seq.h
- ($(srcfile aic7xxx_seq.h))
+ ($(srcfile_base aic7xxx_seq.h))
(cp -a $< $@)
()
)
user_command(aic7xxx_reg.h
- ($(srcfile aic7xxx_reg.h))
+ ($(srcfile_base aic7xxx_reg.h))
(cp -a $< $@)
()
)
_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
