[Kai Germaschewski]
> This looks generally looks okay to me, I don't like the subtle
> difference between stand-alone and partial module, though, probably
> nobody can remember that, anyway ;) And there is really no difference
> in the command line, so why print something different.
The idea was that [M] is printed whenever a new module is born.
(M) means a module is in progress.
If you *really* don't like this distinction, I'll remove it. I thought
it was nice to have, though.
> The LD line also doesn't really depend on whether we're linking a
> module or not, so not sure about the [M] there.
See above.
> If anything, I'd suggest to have it there for a composite object
> which is linked to become a module, and not there for a composite
> object which is linked into the kernel / built-in.o.
That's what the patch does. When I said "composite object" I really
meant "composite module".
> Also, implementation-wise, it may be cleaner to handle things the
> same way '-DMODULE' gets added?
You're probably right. Try this one. (BTW, is there a better way to
set a variable equal to " "?)
Peter
--- 2.5.45/scripts/Makefile.build~ 2002-11-03 07:44:20.000000000 -0600
+++ 2.5.45/scripts/Makefile.build 2002-11-04 13:58:33.000000000 -0600
@@ -53,11 +53,21 @@
# Default is built-in, unless we know otherwise
modkern_cflags := $(CFLAGS_KERNEL)
+quiet_modtag := $(if ,, )
$(real-objs-m) : modkern_cflags := $(CFLAGS_MODULE)
$(real-objs-m:.o=.i) : modkern_cflags := $(CFLAGS_MODULE)
$(real-objs-m:.o=.lst): modkern_cflags := $(CFLAGS_MODULE)
+$(real-objs-m) : quiet_modtag := (M)
+$(real-objs-m:.o=.i) : quiet_modtag := (M)
+$(real-objs-m:.o=.s) : quiet_modtag := (M)
+$(real-objs-m:.o=.lst): quiet_modtag := (M)
+$(obj-m) : quiet_modtag := [M]
+$(obj-m:.o=.i) : quiet_modtag := [M]
+$(obj-m:.o=.s) : quiet_modtag := [M]
+$(obj-m:.o=.lst) : quiet_modtag := [M]
+
$(export-objs) : export_flags := $(EXPORT_FLAGS)
$(export-objs:.o=.i) : export_flags := $(EXPORT_FLAGS)
$(export-objs:.o=.s) : export_flags := $(EXPORT_FLAGS)
@@ -68,19 +78,19 @@
-DKBUILD_BASENAME=$(subst $(comma),_,$(subst -,_,$(*F))) \
$(export_flags)
-quiet_cmd_cc_s_c = CC $@
+quiet_cmd_cc_s_c = CC $(quiet_modtag) $@
cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $<
%.s: %.c FORCE
$(call if_changed_dep,cc_s_c)
-quiet_cmd_cc_i_c = CPP $@
+quiet_cmd_cc_i_c = CPP $(quiet_modtag) $@
cmd_cc_i_c = $(CPP) $(c_flags) -o $@ $<
%.i: %.c FORCE
$(call if_changed_dep,cc_i_c)
-quiet_cmd_cc_o_c = CC $@
+quiet_cmd_cc_o_c = CC $(quiet_modtag) $@
cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $<
%.o: %.c FORCE
@@ -103,13 +113,13 @@
a_flags = -Wp,-MD,$(depfile) $(AFLAGS) $(NOSTDINC_FLAGS) \
$(modkern_aflags) $(EXTRA_AFLAGS) $(AFLAGS_$(*F).o)
-quiet_cmd_as_s_S = CPP $@
+quiet_cmd_as_s_S = CPP $(quiet_modtag) $@
cmd_as_s_S = $(CPP) $(a_flags) -o $@ $<
%.s: %.S FORCE
$(call if_changed_dep,as_s_S)
-quiet_cmd_as_o_S = AS $@
+quiet_cmd_as_o_S = AS $(quiet_modtag) $@
cmd_as_o_S = $(CC) $(a_flags) -c -o $@ $<
%.o: %.S FORCE
@@ -156,7 +166,7 @@
# Rule to link composite objects
#
-quiet_cmd_link_multi = LD $@
+quiet_cmd_link_multi = LD $(quiet_modtag) $@
cmd_link_multi = $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) -r -o $@ $(filter $(addprefix
$(obj)/,$($(subst $(obj)/,,$(@:.o=-objs))) $($(subst $(obj)/,,$(@:.o=-y)))),$^)
# We would rather have a list of rules like
-------------------------------------------------------
This SF.net email is sponsored by: ApacheCon, November 18-21 in
Las Vegas (supported by COMDEX), the only Apache event to be
fully supported by the ASF. http://www.apachecon.com
_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
