Am Freitag, 29. September 2006 00:34 schrieb Roman Zippel: > Hi, > > On Thu, 28 Sep 2006, karsten wiese wrote: > > > enable/disable the qt- and gtk-gui configurator's > > "save" toolbar-button/menu-entry. > > > > The qt-configurator asks the user, if he want's to save the changed > > .config if sym_change_count!=0. > > Ok, then please split the patch a bit differently. > 1. Introduce and use the getter for the change information, which is > actually a boolean, so something like sym_get_changed() would be a better > name. > 2. Cleanup how the change information is managed, e.g. via > sym_set_changed(). This is an internal function, so it doesn't has to be > exported. > 3. Add the callback, but please make the function and object static to the > class. >
Just gave it a try and stumbled over already existing sym_set_changed(). find output (see below) shows the most hits for "sym_change_count" in confdata.c. So how about replacing "sym_change_count" by "bool conf_dirty" and adding "bool conf_get_dirty(void)", "void conf_set_dirty(bool)" ? I'd place "bool conf_dirty", "bool conf_get_dirty(void)" and "void conf_set_dirty(bool)" in confdata.c then. Karsten find . -type f -print0 | xargs -0 -e grep -nH -e sym_change_count ./conf.c:603: } else if (sym_change_count) { ./confdata.c:103: sym_change_count++; ./confdata.c:311: sym_change_count = 0; ./confdata.c:363: sym_change_count += conf_warnings || conf_unsaved; ./confdata.c:431: if (!sym_change_count) ./confdata.c:527: sym_change_count = 0; ./lkc_proto.h:19:P(sym_change_count,int,); ./qconf.cc:1587: if (!sym_change_count) { ./symbol.c:33:int sym_change_count; ./symbol.c:382: sym_change_count++; ./zconf.tab.c_shipped:2138: sym_change_count = 1; ./zconf.y:507: sym_change_count = 1; ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel