On Sun, Sep 16, 2007 at 09:32:58PM +0200, Oleg Verych wrote: > On Sun, Sep 16, 2007 at 08:29:12PM +0200, Sam Ravnborg wrote: > > Hi Oleg. > > Hallo. Nice, you are bringing it back. I'll try to have LKML-like > output this time, not a makefile mess and stuff: > > [] > > I see no value in renaming from asm_offset to asm_value - please drop it. > > Introducing the generic asm-values.h should wait and when you do > > you should be preapred to update all architectures (ecasue otherwise it > > will not happen). > > All archs, are using same syntax. But. > > Interesting exception is MIPS, where tokens are organized and implemented > more nicely, that is where *asm-values* name coming from, actually. One > can see all that text, size, constant tokens in addition to just offsets. > > So, if name change isn't worth, then OK; filename compatibility check, as > one in `linux/Kbuild', is easy to hack as well to remove. > > But nice feature/tool with meaningful name and functionality is just > another thing. > > Opinions? Everyone and their cousin these days knows that asm-offset is constants generated from C and used in assembler. If we benefit from more values in the asm-offset file - let's do it. But there is no reason to change a name that has been used for this purpose for as long as I can remember.
Sam ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kbuild-devel mailing list kbuild-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kbuild-devel