On Thu, Feb 07, 2019 at 06:31:02AM +0000, Vaittinen, Matti wrote:
> Thanks a bunch Dan!
>
>
> ________________________________________
> From: Dan Carpenter [dan.carpen...@oracle.com]
> Sent: Wednesday, February 06, 2019 4:46 PM
> To: kbu...@01.org; Vaittinen, Matti
> Cc: kbuild-...@01.org
> Subject: Re: [RFC PATCH v5 09/10] power: supply: Initial support for ROHM
> BD70528 PMIC charger block
>
> Hi Matti,
>
> > [FYI, it's a private test report for your RFC patch.]
> > 86fff7c9f Matti Vaittinen 2019-02-04 592 ret =
> > find_selector_for_value_low(&warm_charge_curr[0],
> > 86fff7c9f Matti Vaittinen 2019-02-04 593
> > ARRAY_SIZE(warm_charge_curr), ma,
> > 86fff7c9f Matti Vaittinen 2019-02-04 594
> > ®, &found);
> > 86fff7c9f Matti Vaittinen 2019-02-04 595
> > 86fff7c9f Matti Vaittinen 2019-02-04 596 if (!found) {
> > 86fff7c9f Matti Vaittinen 2019-02-04 597 /* There was a gap
> > in supported values and we hit it */
> > 86fff7c9f Matti Vaittinen 2019-02-04 598
> > dev_warn(bdpsy->chip.dev,
> > 86fff7c9f Matti Vaittinen 2019-02-04 599
> > "Unsupported charge current %u mA\n", ma);
> >
> > We could probably set "reg = something;" on this error path.
>
> Actually, I think we must do
>
> if (ret) {
> reg = /* safe value here */
> goto set;
> }
>
> as find_selector_for_value_low() may set "better than default" register value
> even if perfect match was not found. We should use default only if we get non
> zero ret. But Big Thanks for pointing this out! You saved lots of work from
> me here =)
>
> Ps. I guess you send mail to gazillion people during the year so you may not
> remember me or my email address - but just in case you do - can you please
> also include my personal address (mazziesacco...@gmail.com) into recipients
> when mailing to me. Only email client I can use with company mail is the
> outlook web client - it is really a pain to reply to anythng using this :/ I
> use mutt for gmail so it is much more convenient to reply emails using it :)
>
These are automated emails from the Intel zero day built bot. I just
look over the Smatch warnings and hit send. :/ I'm not sure how it
picks the recipient list...
It's not really necessary to reply if you don't want to, also. :P
regards,
dan carpenter
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
