CC: kbuild-...@lists.01.org In-Reply-To: <1617593662-25900-3-git-send-email-tanxiao...@huawei.com> References: <1617593662-25900-3-git-send-email-tanxiao...@huawei.com> TO: Xiaofei Tan <tanxiao...@huawei.com> TO: gre...@linuxfoundation.org TO: jirisl...@kernel.org CC: linux-ker...@vger.kernel.org CC: linux...@openeuler.org CC: Xiaofei Tan <tanxiao...@huawei.com>
Hi Xiaofei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v5.12-rc6 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago config: x86_64-randconfig-m001-20210405 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: drivers/tty/sysrq.c:558 __sysrq_get_key_op() warn: curly braces intended? vim +558 drivers/tty/sysrq.c ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 545 ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 546 /* ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 547 * get and put functions for the table, exposed to modules. ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 548 */ 23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov 2020-05-13 549 static const struct sysrq_key_op *__sysrq_get_key_op(int key) bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 550 { 23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov 2020-05-13 551 const struct sysrq_key_op *op_p = NULL; ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 552 int i; ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 553 ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 554 i = sysrq_key_table_key2index(key); bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 555 if (i != -1) bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 556 op_p = sysrq_key_table[i]; 97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21 557 ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 @558 return op_p; ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 559 } ^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 560 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
