CC: kbuild-...@lists.01.org
CC: Linux Memory Management List <linux...@kvack.org>
TO: Takashi Iwai <ti...@suse.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
master
head:   90d856e71443a2fcacca8e7539bac44d9cb3f7ab
commit: 546c201a891e8439d11a13f5dd3e636ebd94b7d6 [1793/3296] ALSA: riptide: 
Allocate resources with device-managed APIs
:::::: branch date: 3 days ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-m001-20210726 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>

New smatch warnings:
sound/pci/riptide/riptide.c:1860 snd_riptide_create() warn: 'pci' not released 
on lines: 1850.

Old smatch warnings:
sound/pci/riptide/riptide.c:1231 try_to_load_firmware() error: we previously 
assumed 'chip->fw_entry' could be null (see line 1222)

vim +/pci +1860 sound/pci/riptide/riptide.c

109a9638f0fe38 Peter Gruber   2006-03-27  1815  
e23e7a14362072 Bill Pemberton 2012-12-06  1816  static int
546c201a891e84 Takashi Iwai   2021-07-15  1817  snd_riptide_create(struct 
snd_card *card, struct pci_dev *pci)
109a9638f0fe38 Peter Gruber   2006-03-27  1818  {
546c201a891e84 Takashi Iwai   2021-07-15  1819          struct snd_riptide 
*chip = card->private_data;
109a9638f0fe38 Peter Gruber   2006-03-27  1820          struct riptideport 
*hwport;
109a9638f0fe38 Peter Gruber   2006-03-27  1821          int err;
109a9638f0fe38 Peter Gruber   2006-03-27  1822  
546c201a891e84 Takashi Iwai   2021-07-15  1823          err = 
pcim_enable_device(pci);
28c0709921fe13 Takashi Iwai   2021-06-08  1824          if (err < 0)
109a9638f0fe38 Peter Gruber   2006-03-27  1825                  return err;
109a9638f0fe38 Peter Gruber   2006-03-27  1826  
109a9638f0fe38 Peter Gruber   2006-03-27  1827          
spin_lock_init(&chip->lock);
109a9638f0fe38 Peter Gruber   2006-03-27  1828          chip->card = card;
109a9638f0fe38 Peter Gruber   2006-03-27  1829          chip->pci = pci;
109a9638f0fe38 Peter Gruber   2006-03-27  1830          chip->irq = -1;
109a9638f0fe38 Peter Gruber   2006-03-27  1831          chip->openstreams = 0;
109a9638f0fe38 Peter Gruber   2006-03-27  1832          chip->port = 
pci_resource_start(pci, 0);
109a9638f0fe38 Peter Gruber   2006-03-27  1833          chip->received_irqs = 0;
109a9638f0fe38 Peter Gruber   2006-03-27  1834          chip->handled_irqs = 0;
109a9638f0fe38 Peter Gruber   2006-03-27  1835          chip->cif = NULL;
546c201a891e84 Takashi Iwai   2021-07-15  1836          card->private_free = 
snd_riptide_free;
109a9638f0fe38 Peter Gruber   2006-03-27  1837  
546c201a891e84 Takashi Iwai   2021-07-15  1838          err = 
pci_request_regions(pci, "RIPTIDE");
546c201a891e84 Takashi Iwai   2021-07-15  1839          if (err < 0)
546c201a891e84 Takashi Iwai   2021-07-15  1840                  return err;
109a9638f0fe38 Peter Gruber   2006-03-27  1841          hwport = (struct 
riptideport *)chip->port;
109a9638f0fe38 Peter Gruber   2006-03-27  1842          UNSET_AIE(hwport);
109a9638f0fe38 Peter Gruber   2006-03-27  1843  
546c201a891e84 Takashi Iwai   2021-07-15  1844          if 
(devm_request_threaded_irq(&pci->dev, pci->irq,
546c201a891e84 Takashi Iwai   2021-07-15  1845                                  
      snd_riptide_interrupt,
2ac55daffee5af Takashi Iwai   2020-09-03  1846                                  
      riptide_handleirq, IRQF_SHARED,
934c2b6d0cb50f Takashi Iwai   2011-06-10  1847                                  
      KBUILD_MODNAME, chip)) {
109a9638f0fe38 Peter Gruber   2006-03-27  1848                  
snd_printk(KERN_ERR "Riptide: unable to grab IRQ %d\n",
109a9638f0fe38 Peter Gruber   2006-03-27  1849                             
pci->irq);
109a9638f0fe38 Peter Gruber   2006-03-27  1850                  return -EBUSY;
109a9638f0fe38 Peter Gruber   2006-03-27  1851          }
109a9638f0fe38 Peter Gruber   2006-03-27  1852          chip->irq = pci->irq;
3992f78f349f7f Takashi Iwai   2019-12-10  1853          card->sync_irq = 
chip->irq;
109a9638f0fe38 Peter Gruber   2006-03-27  1854          chip->device_id = 
pci->device;
109a9638f0fe38 Peter Gruber   2006-03-27  1855          pci_set_master(pci);
28c0709921fe13 Takashi Iwai   2021-06-08  1856          err = 
snd_riptide_initialize(chip);
546c201a891e84 Takashi Iwai   2021-07-15  1857          if (err < 0)
109a9638f0fe38 Peter Gruber   2006-03-27  1858                  return err;
109a9638f0fe38 Peter Gruber   2006-03-27  1859  
109a9638f0fe38 Peter Gruber   2006-03-27 @1860          return 0;
109a9638f0fe38 Peter Gruber   2006-03-27  1861  }
109a9638f0fe38 Peter Gruber   2006-03-27  1862  

:::::: The code at line 1860 was first introduced by commit
:::::: 109a9638f0fe38915838b7b9acd98e7cfa91797f [ALSA] Add snd-riptide driver 
for Conexant Riptide chip

:::::: TO: Peter Gruber <no...@gmx.net>
:::::: CC: Jaroslav Kysela <pe...@suse.cz>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

Reply via email to