CC: kbuild-...@lists.01.org CC: intel-...@lists.freedesktop.org CC: dri-de...@lists.freedesktop.org TO: "Thomas Hellström" <thomas.hellst...@linux.intel.com> CC: Matthew Auld <matthew.a...@intel.com> CC: "Michael J. Ruhl" <michael.j.r...@intel.com> CC: Jason Ekstrand <ja...@jlekstrand.net>
tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next
head: cdb35d1ed6d216978521b75927acb3b8c50a6cac
commit: cdb35d1ed6d216978521b75927acb3b8c50a6cac [8/8] drm/i915/gem: Migrate to
system at dma-buf attach time (v7)
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago
config: x86_64-randconfig-m001-20210726 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:189 i915_gem_dmabuf_attach() error:
uninitialized symbol 'err'.
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:189 __i915_gem_object_lock() error:
we previously assumed 'ww' could be null (see line 178)
vim +/err +189 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
346400c8010791 drivers/gpu/drm/i915/i915_gem_dmabuf.c Tiago Vignatti
2015-12-22 162
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 163 static int i915_gem_dmabuf_attach(struct dma_buf *dmabuf,
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 164 struct dma_buf_attachment
*attach)
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 165 {
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 166 struct drm_i915_gem_object *obj = dma_buf_to_obj(dmabuf);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 167 struct i915_gem_ww_ctx ww;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 168 int err;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 169
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 170 if (!i915_gem_object_can_migrate(obj, INTEL_REGION_SMEM))
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 171 return -EOPNOTSUPP;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 172
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 173 for_i915_gem_ww(&ww, err, true) {
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 174 err = i915_gem_object_lock(obj, &ww);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 175 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 176 continue;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 177
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 178 err = i915_gem_object_migrate(obj, &ww,
INTEL_REGION_SMEM);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 179 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 180 continue;
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 181
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 182 err = i915_gem_object_wait_migration(obj, 0);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 183 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 184 continue;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 185
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 186 err = i915_gem_object_pin_pages(obj);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 187 }
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 188
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 @189 return err;
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 190 }
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström
2021-07-23 191
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
