CC: clang-built-li...@googlegroups.com CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Coly Li <col...@suse.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git nvdimm-meta head: 80de5dc2a60df7adc4cdd2ed063dae948a93e089 commit: ab89b985340028f590e633e9095b3c6255a74fc2 [11/12] bcache: read jset from NVDIMM pages for journal replay :::::: branch date: 8 days ago :::::: commit date: 8 days ago config: riscv-randconfig-c006-20210825 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?id=ab89b985340028f590e633e9095b3c6255a74fc2 git remote add bcache https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git git fetch --no-tags bcache nvdimm-meta git checkout ab89b985340028f590e633e9095b3c6255a74fc2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> clang-analyzer warnings: (new ones prefixed by >>) can_skb_prv(skb)->skbcnt = 0; ^~~~~~~~~~~~~~~~ net/can/raw.c:820:24: note: Value assigned to field 'end' err = memcpy_from_msg(skb_put(skb, size), msg, size); ^~~~~~~~~~~~~~~~~~ net/can/raw.c:821:6: note: 'err' is >= 0 if (err < 0) ^~~ net/can/raw.c:821:2: note: Taking false branch if (err < 0) ^ net/can/raw.c:824:2: note: Calling 'skb_setup_tx_timestamp' skb_setup_tx_timestamp(skb, sk->sk_tsflags); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/net/sock.h:2561:39: note: Passing value via 3rd parameter 'tx_flags' _sock_tx_timestamp(skb->sk, tsflags, &skb_shinfo(skb)->tx_flags, ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/net/sock.h:2561:2: note: Calling '_sock_tx_timestamp' _sock_tx_timestamp(skb->sk, tsflags, &skb_shinfo(skb)->tx_flags, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/net/sock.h:2543:6: note: Assuming 'tsflags' is not equal to 0 if (unlikely(tsflags)) { ^ include/linux/compiler.h:48:24: note: expanded from macro 'unlikely' # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:33:32: note: expanded from macro '__branch_check__' ______r = __builtin_expect(!!(x), expect); \ ^~~~ include/net/sock.h:2543:2: note: Taking true branch if (unlikely(tsflags)) { ^ include/net/sock.h:2545:7: note: Assuming the condition is true if (tsflags & SOF_TIMESTAMPING_OPT_ID && tskey && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/net/sock.h:2545:7: note: Left side of '&&' is true include/net/sock.h:2545:44: note: Assuming 'tskey' is null if (tsflags & SOF_TIMESTAMPING_OPT_ID && tskey && ^~~~~ include/net/sock.h:2545:7: note: Assuming pointer value is null if (tsflags & SOF_TIMESTAMPING_OPT_ID && tskey && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/net/sock.h:2545:50: note: Left side of '&&' is false if (tsflags & SOF_TIMESTAMPING_OPT_ID && tskey && ^ include/net/sock.h:2549:6: note: Assuming the condition is false if (unlikely(sock_flag(sk, SOCK_WIFI_STATUS))) ^ include/linux/compiler.h:48:24: note: expanded from macro 'unlikely' # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:33:32: note: expanded from macro '__branch_check__' ______r = __builtin_expect(!!(x), expect); \ ^~~~ include/net/sock.h:2549:2: note: Taking true branch if (unlikely(sock_flag(sk, SOCK_WIFI_STATUS))) ^ include/net/sock.h:2550:13: note: Dereference of null pointer (loaded from variable 'tx_flags') *tx_flags |= SKBTX_WIFI_STATUS; ~~~~~~~~ ^ Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 5 warnings generated. drivers/net/ppp/pppoe.c:1158:2: warning: Value stored to 'pde' is never read [clang-analyzer-deadcode.DeadStores] pde = proc_create_net("pppoe", 0444, net->proc_net, ^ drivers/net/ppp/pppoe.c:1158:2: note: Value stored to 'pde' is never read Suppressed 4 warnings (3 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 3 warnings generated. Suppressed 3 warnings (3 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 2 warnings generated. Suppressed 2 warnings (2 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 7 warnings generated. >> drivers/md/bcache/journal.c:123:27: warning: Access to field 'keys' results >> in a dereference of an undefined pointer value (loaded from variable 'j') >> [clang-analyzer-core.NullDereference] size_t blocks, bytes = set_bytes(j); ^ drivers/md/bcache/bset.h:262:23: note: expanded from macro 'set_bytes' #define set_bytes(i) __set_bytes(i, i->keys) ^ drivers/md/bcache/bset.h:261:43: note: expanded from macro '__set_bytes' #define __set_bytes(i, k) (sizeof(*(i)) + (k) * sizeof(uint64_t)) ^ drivers/md/bcache/journal.c:240:2: note: Taking false branch if (bch_has_feature_nvdimm_meta(&ca->sb)) { ^ drivers/md/bcache/journal.c:246:2: note: Taking false branch pr_debug("%u journal buckets\n", ca->sb.njournal_buckets); ^ include/linux/printk.h:477:2: note: expanded from macro 'pr_debug' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^ include/linux/printk.h:140:2: note: expanded from macro 'no_printk' if (0) \ ^ drivers/md/bcache/journal.c:252:14: note: Assuming 'i' is < field 'njournal_buckets' for (i = 0; i < ca->sb.njournal_buckets; i++) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/md/bcache/journal.c:252:2: note: Loop condition is true. Entering loop body for (i = 0; i < ca->sb.njournal_buckets; i++) { ^ drivers/md/bcache/journal.c:260:3: note: Taking false branch if (test_bit(l, bitmap)) ^ drivers/md/bcache/journal.c:263:7: note: 'ret' is >= 0 if (read_bucket(l)) ^ drivers/md/bcache/journal.c:224:7: note: expanded from macro 'read_bucket' if (ret < 0) \ ^~~ drivers/md/bcache/journal.c:263:7: note: Taking false branch if (read_bucket(l)) ^ drivers/md/bcache/journal.c:224:3: note: expanded from macro 'read_bucket' if (ret < 0) \ ^ drivers/md/bcache/journal.c:263:3: note: Taking false branch if (read_bucket(l)) ^ drivers/md/bcache/journal.c:252:14: note: Assuming 'i' is < field 'njournal_buckets' for (i = 0; i < ca->sb.njournal_buckets; i++) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/md/bcache/journal.c:252:2: note: Loop condition is true. Entering loop body for (i = 0; i < ca->sb.njournal_buckets; i++) { ^ drivers/md/bcache/journal.c:260:7: note: Assuming the condition is false if (test_bit(l, bitmap)) ^~~~~~~~~~~~~~~~~~~ drivers/md/bcache/journal.c:260:3: note: Taking false branch if (test_bit(l, bitmap)) ^ drivers/md/bcache/journal.c:263:7: note: Calling 'journal_read_bucket' if (read_bucket(l)) ^ drivers/md/bcache/journal.c:222:9: note: expanded from macro 'read_bucket' ret = journal_read_bucket(ca, list, b); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/md/bcache/journal.c:87:2: note: 'j' declared without an initial value struct jset *j; ^~~~~~~~~~~~~~ drivers/md/bcache/journal.c:94:2: note: Taking false branch pr_debug("reading %u\n", bucket_index); ^ include/linux/printk.h:477:2: note: expanded from macro 'pr_debug' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^ include/linux/printk.h:140:2: note: expanded from macro 'no_printk' if (0) \ ^ drivers/md/bcache/journal.c:96:9: note: Assuming 'offset' is < field 'bucket_size' while (offset < ca->sb.bucket_size) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/md/bcache/journal.c:96:2: note: Loop condition is true. Entering loop body while (offset < ca->sb.bucket_size) { ^ drivers/md/bcache/journal.c:98:9: note: Assuming '__UNIQUE_ID___x309' is < '__UNIQUE_ID___y310' len = min_t(unsigned int, left, PAGE_SECTORS << JSET_BITS); ^ include/linux/minmax.h:104:27: note: expanded from macro 'min_t' #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:38:3: note: expanded from macro '__careful_cmp' __cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:33:3: note: expanded from macro '__cmp_once' __cmp(unique_x, unique_y, op); }) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:28:26: note: expanded from macro '__cmp' #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) ^~~~~~~~~~ drivers/md/bcache/journal.c:98:9: note: '?' condition is true len = min_t(unsigned int, left, PAGE_SECTORS << JSET_BITS); ^ include/linux/minmax.h:104:27: note: expanded from macro 'min_t' #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) vim +123 drivers/md/bcache/journal.c cafe563591446c Kent Overstreet 2013-03-23 115 cafe563591446c Kent Overstreet 2013-03-23 116 /* This function could be simpler now since we no longer write cafe563591446c Kent Overstreet 2013-03-23 117 * journal entries that overlap bucket boundaries; this means cafe563591446c Kent Overstreet 2013-03-23 118 * the start of a bucket will always have a valid journal entry cafe563591446c Kent Overstreet 2013-03-23 119 * if it has any journal entries at all. cafe563591446c Kent Overstreet 2013-03-23 120 */ cafe563591446c Kent Overstreet 2013-03-23 121 while (len) { cafe563591446c Kent Overstreet 2013-03-23 122 struct list_head *where; cafe563591446c Kent Overstreet 2013-03-23 @123 size_t blocks, bytes = set_bytes(j); cafe563591446c Kent Overstreet 2013-03-23 124 b3fa7e77e67e64 Kent Overstreet 2013-08-05 125 if (j->magic != jset_magic(&ca->sb)) { 46f5aa8806e34f Joe Perches 2020-05-27 126 pr_debug("%u: bad magic\n", bucket_index); cafe563591446c Kent Overstreet 2013-03-23 127 return ret; b3fa7e77e67e64 Kent Overstreet 2013-08-05 128 } cafe563591446c Kent Overstreet 2013-03-23 129 b3fa7e77e67e64 Kent Overstreet 2013-08-05 130 if (bytes > left << 9 || b3fa7e77e67e64 Kent Overstreet 2013-08-05 131 bytes > PAGE_SIZE << JSET_BITS) { 46f5aa8806e34f Joe Perches 2020-05-27 132 pr_info("%u: too big, %zu bytes, offset %u\n", b3fa7e77e67e64 Kent Overstreet 2013-08-05 133 bucket_index, bytes, offset); cafe563591446c Kent Overstreet 2013-03-23 134 return ret; b3fa7e77e67e64 Kent Overstreet 2013-08-05 135 } cafe563591446c Kent Overstreet 2013-03-23 136 cafe563591446c Kent Overstreet 2013-03-23 137 if (bytes > len << 9) cafe563591446c Kent Overstreet 2013-03-23 138 goto reread; cafe563591446c Kent Overstreet 2013-03-23 139 b3fa7e77e67e64 Kent Overstreet 2013-08-05 140 if (j->csum != csum_set(j)) { 46f5aa8806e34f Joe Perches 2020-05-27 141 pr_info("%u: bad csum, %zu bytes, offset %u\n", b3fa7e77e67e64 Kent Overstreet 2013-08-05 142 bucket_index, bytes, offset); cafe563591446c Kent Overstreet 2013-03-23 143 return ret; b3fa7e77e67e64 Kent Overstreet 2013-08-05 144 } cafe563591446c Kent Overstreet 2013-03-23 145 4e1ebae3ee4e0c Coly Li 2020-10-01 146 blocks = set_blocks(j, block_bytes(ca)); cafe563591446c Kent Overstreet 2013-03-23 147 2464b693148e5d Coly Li 2019-06-28 148 /* 2464b693148e5d Coly Li 2019-06-28 149 * Nodes in 'list' are in linear increasing order of 2464b693148e5d Coly Li 2019-06-28 150 * i->j.seq, the node on head has the smallest (oldest) 2464b693148e5d Coly Li 2019-06-28 151 * journal seq, the node on tail has the biggest 2464b693148e5d Coly Li 2019-06-28 152 * (latest) journal seq. 2464b693148e5d Coly Li 2019-06-28 153 */ 2464b693148e5d Coly Li 2019-06-28 154 2464b693148e5d Coly Li 2019-06-28 155 /* 2464b693148e5d Coly Li 2019-06-28 156 * Check from the oldest jset for last_seq. If 2464b693148e5d Coly Li 2019-06-28 157 * i->j.seq < j->last_seq, it means the oldest jset 2464b693148e5d Coly Li 2019-06-28 158 * in list is expired and useless, remove it from 9c9b81c45619e7 Bhaskar Chowdhury 2021-04-11 159 * this list. Otherwise, j is a candidate jset for 2464b693148e5d Coly Li 2019-06-28 160 * further following checks. 2464b693148e5d Coly Li 2019-06-28 161 */ cafe563591446c Kent Overstreet 2013-03-23 162 while (!list_empty(list)) { cafe563591446c Kent Overstreet 2013-03-23 163 i = list_first_entry(list, cafe563591446c Kent Overstreet 2013-03-23 164 struct journal_replay, list); cafe563591446c Kent Overstreet 2013-03-23 165 if (i->j.seq >= j->last_seq) cafe563591446c Kent Overstreet 2013-03-23 166 break; cafe563591446c Kent Overstreet 2013-03-23 167 list_del(&i->list); cafe563591446c Kent Overstreet 2013-03-23 168 kfree(i); cafe563591446c Kent Overstreet 2013-03-23 169 } cafe563591446c Kent Overstreet 2013-03-23 170 2464b693148e5d Coly Li 2019-06-28 171 /* iterate list in reverse order (from latest jset) */ cafe563591446c Kent Overstreet 2013-03-23 172 list_for_each_entry_reverse(i, list, list) { cafe563591446c Kent Overstreet 2013-03-23 173 if (j->seq == i->j.seq) cafe563591446c Kent Overstreet 2013-03-23 174 goto next_set; cafe563591446c Kent Overstreet 2013-03-23 175 2464b693148e5d Coly Li 2019-06-28 176 /* 2464b693148e5d Coly Li 2019-06-28 177 * if j->seq is less than any i->j.last_seq 2464b693148e5d Coly Li 2019-06-28 178 * in list, j is an expired and useless jset. 2464b693148e5d Coly Li 2019-06-28 179 */ cafe563591446c Kent Overstreet 2013-03-23 180 if (j->seq < i->j.last_seq) cafe563591446c Kent Overstreet 2013-03-23 181 goto next_set; cafe563591446c Kent Overstreet 2013-03-23 182 2464b693148e5d Coly Li 2019-06-28 183 /* 2464b693148e5d Coly Li 2019-06-28 184 * 'where' points to first jset in list which 2464b693148e5d Coly Li 2019-06-28 185 * is elder then j. 2464b693148e5d Coly Li 2019-06-28 186 */ cafe563591446c Kent Overstreet 2013-03-23 187 if (j->seq > i->j.seq) { cafe563591446c Kent Overstreet 2013-03-23 188 where = &i->list; cafe563591446c Kent Overstreet 2013-03-23 189 goto add; cafe563591446c Kent Overstreet 2013-03-23 190 } cafe563591446c Kent Overstreet 2013-03-23 191 } cafe563591446c Kent Overstreet 2013-03-23 192 cafe563591446c Kent Overstreet 2013-03-23 193 where = list; cafe563591446c Kent Overstreet 2013-03-23 194 add: cafe563591446c Kent Overstreet 2013-03-23 195 i = kmalloc(offsetof(struct journal_replay, j) + cafe563591446c Kent Overstreet 2013-03-23 196 bytes, GFP_KERNEL); cafe563591446c Kent Overstreet 2013-03-23 197 if (!i) cafe563591446c Kent Overstreet 2013-03-23 198 return -ENOMEM; cafe563591446c Kent Overstreet 2013-03-23 199 memcpy(&i->j, j, bytes); 2464b693148e5d Coly Li 2019-06-28 200 /* Add to the location after 'where' points to */ cafe563591446c Kent Overstreet 2013-03-23 201 list_add(&i->list, where); cafe563591446c Kent Overstreet 2013-03-23 202 ret = 1; cafe563591446c Kent Overstreet 2013-03-23 203 a231f07a5fe30a Coly Li 2019-06-28 204 if (j->seq > ja->seq[bucket_index]) cafe563591446c Kent Overstreet 2013-03-23 205 ja->seq[bucket_index] = j->seq; cafe563591446c Kent Overstreet 2013-03-23 206 next_set: cafe563591446c Kent Overstreet 2013-03-23 207 offset += blocks * ca->sb.block_size; cafe563591446c Kent Overstreet 2013-03-23 208 len -= blocks * ca->sb.block_size; cafe563591446c Kent Overstreet 2013-03-23 209 j = ((void *) j) + blocks * block_bytes(ca); cafe563591446c Kent Overstreet 2013-03-23 210 } cafe563591446c Kent Overstreet 2013-03-23 211 } cafe563591446c Kent Overstreet 2013-03-23 212 cafe563591446c Kent Overstreet 2013-03-23 213 return ret; cafe563591446c Kent Overstreet 2013-03-23 214 } cafe563591446c Kent Overstreet 2013-03-23 215 :::::: The code at line 123 was first introduced by commit :::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache :::::: TO: Kent Overstreet <koverstr...@google.com> :::::: CC: Kent Overstreet <koverstr...@google.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
