CC: l...@lists.linux.dev CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: linux-ker...@vger.kernel.org TO: Gaurav Srivastava <gaurav.srivast...@broadcom.com> CC: "Martin K. Petersen" <martin.peter...@oracle.com> CC: Hannes Reinecke <h...@suse.de> CC: James Smart <jsmart2...@gmail.com> CC: Muneendra Kumar <muneendra.ku...@broadcom.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 14702b3b2438e2f2d07ae93b5d695c166e5c83d1 commit: 742b0cf87a8f9219101d68a7b4c6317db057ac58 scsi: lpfc: vmid: Implement CT commands for appid date: 9 months ago :::::: branch date: 16 hours ago :::::: commit date: 9 months ago config: arm-randconfig-c002-20220312 (https://download.01.org/0day-ci/archive/20220320/202203202333.zi1nj7s5-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=742b0cf87a8f9219101d68a7b4c6317db057ac58 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 742b0cf87a8f9219101d68a7b4c6317db057ac58 # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> clang-analyzer warnings: (new ones prefixed by >>) if (host->quirks & SDHCI_QUIRK_BROKEN_TIMEOUT_VAL) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci.c:941:2: note: Taking true branch if (host->quirks & SDHCI_QUIRK_BROKEN_TIMEOUT_VAL) ^ drivers/mmc/host/sdhci.c:1020:13: note: Returning from 'sdhci_calc_timeout' u8 count = sdhci_calc_timeout(host, cmd, &too_big); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci.c:1022:6: note: 'too_big' is true if (too_big && ^~~~~~~ drivers/mmc/host/sdhci.c:1022:6: note: Left side of '&&' is true drivers/mmc/host/sdhci.c:1023:6: note: Assuming the condition is true host->quirks2 & SDHCI_QUIRK2_DISABLE_HW_TIMEOUT) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci.c:1022:2: note: Taking true branch if (too_big && ^ drivers/mmc/host/sdhci.c:1024:31: note: Passing null pointer value via 2nd parameter 'cmd' sdhci_calc_sw_timeout(host, cmd); ^~~ drivers/mmc/host/sdhci.c:1024:3: note: Calling 'sdhci_calc_sw_timeout' sdhci_calc_sw_timeout(host, cmd); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci.c:896:26: note: Access to field 'data' results in a dereference of a null pointer (loaded from variable 'cmd') struct mmc_data *data = cmd->data; ^~~ Suppressed 6 warnings (6 in non-user code). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. drivers/scsi/qla2xxx/qla_isr.c:2992:14: warning: Although the value stored to 'par_sense_len' is used in the enclosing expression, the value is never actually read from 'par_sense_len' [clang-analyzer-deadcode.DeadStores] sense_len = par_sense_len = rsp_info_len = resid_len = ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_isr.c:2992:14: note: Although the value stored to 'par_sense_len' is used in the enclosing expression, the value is never actually read from 'par_sense_len' sense_len = par_sense_len = rsp_info_len = resid_len = ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ Suppressed 7 warnings (6 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 7 warnings generated. Suppressed 7 warnings (6 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 8 warnings generated. Suppressed 8 warnings (7 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 16 warnings generated. drivers/scsi/qla2xxx/qla_sup.c:1754:2: warning: Value stored to 'gpio_data' is never read [clang-analyzer-deadcode.DeadStores] gpio_data = rd_reg_dword(®->gpiod); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:1754:2: note: Value stored to 'gpio_data' is never read gpio_data = rd_reg_dword(®->gpiod); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:1832:4: warning: Value stored to 'rval' is never read [clang-analyzer-deadcode.DeadStores] rval = qla81xx_set_led_config(vha, led_cfg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:1832:4: note: Value stored to 'rval' is never read rval = qla81xx_set_led_config(vha, led_cfg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:1846:4: warning: Value stored to 'rval' is never read [clang-analyzer-deadcode.DeadStores] rval = qla81xx_set_led_config(vha, led_cfg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:1846:4: note: Value stored to 'rval' is never read rval = qla81xx_set_led_config(vha, led_cfg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2760:5: warning: Value stored to 'fw_array' is never read [clang-analyzer-deadcode.DeadStores] fw_array += risc_size; ^ ~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2760:5: note: Value stored to 'fw_array' is never read fw_array += risc_size; ^ ~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2770:4: warning: Value stored to 'risc_attr' is never read [clang-analyzer-deadcode.DeadStores] risc_attr = be32_to_cpu(fw_array[9]); ^ drivers/scsi/qla2xxx/qla_sup.c:2770:4: note: Value stored to 'risc_attr' is never read drivers/scsi/qla2xxx/qla_sup.c:2773:4: warning: Value stored to 'fw_array' is never read [clang-analyzer-deadcode.DeadStores] fw_array += risc_size; ^ ~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2773:4: note: Value stored to 'fw_array' is never read fw_array += risc_size; ^ ~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2914:3: warning: Value stored to 'fdata' is never read [clang-analyzer-deadcode.DeadStores] fdata = (faddr & sec_mask) << 2; ^ ~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:2914:3: note: Value stored to 'fdata' is never read fdata = (faddr & sec_mask) << 2; ^ ~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/qla2xxx/qla_sup.c:3183:2: warning: Value stored to 'last_image' is never read [clang-analyzer-deadcode.DeadStores] last_image = 1; ^ ~ drivers/scsi/qla2xxx/qla_sup.c:3183:2: note: Value stored to 'last_image' is never read last_image = 1; ^ ~ drivers/scsi/qla2xxx/qla_sup.c:3313:2: warning: Value stored to 'last_image' is never read [clang-analyzer-deadcode.DeadStores] last_image = 1; ^ ~ drivers/scsi/qla2xxx/qla_sup.c:3313:2: note: Value stored to 'last_image' is never read last_image = 1; ^ ~ Suppressed 7 warnings (6 in non-user code, 1 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 18 warnings generated. >> drivers/scsi/lpfc/lpfc_ct.c:3955:2: warning: Value stored to 'size' is never >> read [clang-analyzer-deadcode.DeadStores] size = 0; ^ ~ drivers/scsi/lpfc/lpfc_ct.c:3955:2: note: Value stored to 'size' is never read size = 0; ^ ~ Suppressed 17 warnings (8 in non-user code, 9 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 22 warnings generated. drivers/scsi/lpfc/lpfc_els.c:4463:24: warning: Access to field 'virt' results in a dereference of a null pointer (loaded from variable 'buf_ptr') [clang-analyzer-core.NullDereference] lpfc_mbuf_free(phba, buf_ptr->virt, buf_ptr->phys); ^ drivers/scsi/lpfc/lpfc_els.c:10789:6: note: Assuming 'ndlp' is non-null if (!ndlp || ndlp->nlp_state != NLP_STE_UNMAPPED_NODE) ^~~~~ drivers/scsi/lpfc/lpfc_els.c:10789:6: note: Left side of '||' is false drivers/scsi/lpfc/lpfc_els.c:10789:15: note: Assuming field 'nlp_state' is equal to NLP_STE_UNMAPPED_NODE if (!ndlp || ndlp->nlp_state != NLP_STE_UNMAPPED_NODE) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:10789:2: note: Taking false branch if (!ndlp || ndlp->nlp_state != NLP_STE_UNMAPPED_NODE) ^ drivers/scsi/lpfc/lpfc_els.c:10792:9: note: Assuming the condition is true prsp = list_get_first(&dmabuf->list, struct lpfc_dmabuf, list); ^ drivers/scsi/lpfc/lpfc_scsi.h:38:3: note: expanded from macro 'list_get_first' (list_empty(list)) ? NULL : \ ^~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:10792:9: note: '?' condition is true prsp = list_get_first(&dmabuf->list, struct lpfc_dmabuf, list); ^ drivers/scsi/lpfc/lpfc_scsi.h:38:2: note: expanded from macro 'list_get_first' (list_empty(list)) ? NULL : \ ^ drivers/scsi/lpfc/lpfc_els.c:10793:7: note: 'prsp' is null if (!prsp) ^~~~ drivers/scsi/lpfc/lpfc_els.c:10793:2: note: Taking true branch if (!prsp) ^ drivers/scsi/lpfc/lpfc_els.c:10794:3: note: Control jumps to line 10822 goto out; ^ drivers/scsi/lpfc/lpfc_els.c:10823:2: note: Calling 'lpfc_els_free_iocb' lpfc_els_free_iocb(phba, icmdiocb); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4527:15: note: Field 'context2' is non-null if (elsiocb->context2) { ^ drivers/scsi/lpfc/lpfc_els.c:4527:2: note: Taking true branch if (elsiocb->context2) { ^ drivers/scsi/lpfc/lpfc_els.c:4528:7: note: Assuming the condition is false if (elsiocb->iocb_flag & LPFC_DELAY_MEM_FREE) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4528:3: note: Taking false branch if (elsiocb->iocb_flag & LPFC_DELAY_MEM_FREE) { ^ drivers/scsi/lpfc/lpfc_els.c:4555:4: note: Calling 'lpfc_els_free_data' lpfc_els_free_data(phba, buf_ptr1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4459:6: note: Assuming the condition is true if (!list_empty(&buf_ptr1->list)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4459:2: note: Taking true branch if (!list_empty(&buf_ptr1->list)) { ^ drivers/scsi/lpfc/lpfc_els.c:4460:37: note: Null pointer value stored to 'buf_ptr' list_remove_head(&buf_ptr1->list, buf_ptr, ^ drivers/scsi/lpfc/lpfc_scsi.h:30:2: note: expanded from macro 'list_remove_head' entry = NULL; \ ^~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4460:3: note: Assuming the condition is false list_remove_head(&buf_ptr1->list, buf_ptr, ^ drivers/scsi/lpfc/lpfc_scsi.h:31:6: note: expanded from macro 'list_remove_head' if (!list_empty(list)) { \ ^~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4460:3: note: Taking false branch list_remove_head(&buf_ptr1->list, buf_ptr, ^ drivers/scsi/lpfc/lpfc_scsi.h:31:2: note: expanded from macro 'list_remove_head' if (!list_empty(list)) { \ ^ drivers/scsi/lpfc/lpfc_els.c:4460:3: note: Loop condition is false. Exiting loop list_remove_head(&buf_ptr1->list, buf_ptr, ^ drivers/scsi/lpfc/lpfc_scsi.h:29:2: note: expanded from macro 'list_remove_head' do { \ ^ drivers/scsi/lpfc/lpfc_els.c:4463:24: note: Access to field 'virt' results in a dereference of a null pointer (loaded from variable 'buf_ptr') lpfc_mbuf_free(phba, buf_ptr->virt, buf_ptr->phys); ^~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4913:3: warning: Value stored to 'pcmd' is never read [clang-analyzer-deadcode.DeadStores] pcmd += sizeof(uint32_t); ^ ~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:4913:3: note: Value stored to 'pcmd' is never read pcmd += sizeof(uint32_t); ^ ~~~~~~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_els.c:8477:4: warning: Value stored to 'cmd' is never read [clang-analyzer-deadcode.DeadStores] vim +/size +3955 drivers/scsi/lpfc/lpfc_ct.c 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3883 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3884 /** 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3885 * lpfc_vmid_cmd - Build and send a FDMI cmd to the specified NPort 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3886 * @vport: pointer to a host virtual N_Port data structure. 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3887 * @ndlp: ndlp to send FDMI cmd to (if NULL use FDMI_DID) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3888 * cmdcode: FDMI command to send 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3889 * mask: Mask of HBA or PORT Attributes to send 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3890 * 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3891 * Builds and sends a FDMI command using the CT subsystem. 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3892 */ 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3893 int 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3894 lpfc_vmid_cmd(struct lpfc_vport *vport, 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3895 int cmdcode, struct lpfc_vmid *vmid) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3896 { 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3897 struct lpfc_hba *phba = vport->phba; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3898 struct lpfc_dmabuf *mp, *bmp; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3899 struct lpfc_sli_ct_request *ctreq; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3900 struct ulp_bde64 *bpl; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3901 u32 size; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3902 u32 rsp_size; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3903 u8 *data; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3904 struct lpfc_vmid_rapp_ident_list *rap; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3905 struct lpfc_vmid_dapp_ident_list *dap; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3906 u8 retry = 0; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3907 struct lpfc_nodelist *ndlp; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3908 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3909 void (*cmpl)(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3910 struct lpfc_iocbq *rspiocb); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3911 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3912 ndlp = lpfc_findnode_did(vport, FDMI_DID); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3913 if (!ndlp || ndlp->nlp_state != NLP_STE_UNMAPPED_NODE) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3914 return 0; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3915 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3916 cmpl = lpfc_cmpl_ct_cmd_vmid; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3917 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3918 /* fill in BDEs for command */ 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3919 /* Allocate buffer for command payload */ 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3920 mp = kmalloc(sizeof(*mp), GFP_KERNEL); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3921 if (!mp) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3922 goto vmid_free_mp_exit; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3923 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3924 mp->virt = lpfc_mbuf_alloc(phba, 0, &mp->phys); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3925 if (!mp->virt) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3926 goto vmid_free_mp_virt_exit; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3927 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3928 /* Allocate buffer for Buffer ptr list */ 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3929 bmp = kmalloc(sizeof(*bmp), GFP_KERNEL); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3930 if (!bmp) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3931 goto vmid_free_bmp_exit; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3932 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3933 bmp->virt = lpfc_mbuf_alloc(phba, 0, &bmp->phys); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3934 if (!bmp->virt) 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3935 goto vmid_free_bmp_virt_exit; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3936 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3937 INIT_LIST_HEAD(&mp->list); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3938 INIT_LIST_HEAD(&bmp->list); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3939 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3940 lpfc_printf_vlog(vport, KERN_INFO, LOG_DISCOVERY, 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3941 "3275 VMID Request Data: x%x x%x x%x\n", 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3942 vport->fc_flag, vport->port_state, cmdcode); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3943 ctreq = (struct lpfc_sli_ct_request *)mp->virt; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3944 data = mp->virt; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3945 /* First populate the CT_IU preamble */ 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3946 memset(data, 0, LPFC_BPL_SIZE); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3947 ctreq->RevisionId.bits.Revision = SLI_CT_REVISION; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3948 ctreq->RevisionId.bits.InId = 0; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3949 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3950 ctreq->FsType = SLI_CT_MANAGEMENT_SERVICE; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3951 ctreq->FsSubType = SLI_CT_APP_SEV_Subtypes; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3952 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3953 ctreq->CommandResponse.bits.CmdRsp = cpu_to_be16(cmdcode); 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 3954 rsp_size = LPFC_BPL_SIZE; 742b0cf87a8f92 Gaurav Srivastava 2021-06-08 @3955 size = 0; -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
