CC: kbuild-...@lists.01.org BCC: l...@intel.com In-Reply-To: <6226a016389e034fd9c208b3a7a75edd01aba6f4.1647858505.git.lore...@kernel.org> References: <6226a016389e034fd9c208b3a7a75edd01aba6f4.1647858505.git.lore...@kernel.org> TO: Lorenzo Bianconi <lore...@kernel.org> TO: johan...@sipsolutions.net CC: n...@nbd.name CC: linux-wirel...@vger.kernel.org CC: lorenzo.bianc...@redhat.com CC: ryder....@mediatek.com CC: evelyn.t...@mediatek.com CC: chui-hao.c...@mediatek.com CC: j...@w1.fi
Hi Lorenzo, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-next/main] [also build test WARNING on wireless/main kvalo-ath/ath-next v5.17 next-20220321] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mac80211-introduce-BSS-color-collision-detection/20220321-183456 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago config: nios2-randconfig-m031-20220321 (https://download.01.org/0day-ci/archive/20220322/202203220555.bhvseahe-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> New smatch warnings: net/mac80211/rx.c:3218 ieee80211_rx_check_bss_color_collision() warn: should '(((1))) << color' be a 64 bit type? Old smatch warnings: net/mac80211/rx.c:877 ieee80211_rx_monitor() warn: variable dereferenced before check 'origskb' (see line 770) arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: uninitialized symbol 'sp'. vim +3218 net/mac80211/rx.c fea147328908b7 Jouni Malinen 2009-01-08 3180 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3181 static void 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3182 ieee80211_rx_check_bss_color_collision(struct ieee80211_rx_data *rx) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3183 { 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3184 struct ieee80211_mgmt *mgmt = (void *)rx->skb->data; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3185 const struct element *ie; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3186 size_t baselen; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3187 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3188 if (!wiphy_ext_feature_isset(rx->local->hw.wiphy, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3189 NL80211_EXT_FEATURE_BSS_COLOR)) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3190 return; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3191 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3192 if (wiphy_ext_feature_isset(rx->local->hw.wiphy, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3193 NL80211_EXT_FEATURE_HW_COLOR_COLLISION)) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3194 return; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3195 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3196 baselen = mgmt->u.beacon.variable - rx->skb->data; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3197 if (baselen > rx->skb->len) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3198 return; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3199 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3200 ie = cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3201 mgmt->u.beacon.variable, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3202 rx->skb->len - baselen); 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3203 if (ie && ie->datalen >= sizeof(struct ieee80211_he_operation) && 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3204 ie->datalen >= ieee80211_he_oper_size(ie->data + 1)) { 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3205 struct ieee80211_bss_conf *bss_conf = &rx->sdata->vif.bss_conf; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3206 const struct ieee80211_he_operation *he_oper; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3207 u8 color; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3208 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3209 he_oper = (void *)(ie->data + 1); 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3210 if (le32_get_bits(he_oper->he_oper_params, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3211 IEEE80211_HE_OPERATION_BSS_COLOR_DISABLED)) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3212 return; 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3213 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3214 color = le32_get_bits(he_oper->he_oper_params, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3215 IEEE80211_HE_OPERATION_BSS_COLOR_MASK); 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3216 if (color == bss_conf->he_bss_color.color) 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3217 ieeee80211_obss_color_collision_notify(&rx->sdata->vif, 964596b43c17b4 Lorenzo Bianconi 2022-03-21 @3218 BIT(color)); 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3219 } 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3220 } 964596b43c17b4 Lorenzo Bianconi 2022-03-21 3221 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
