CC: kbuild-...@lists.01.org BCC: l...@intel.com In-Reply-To: <1647965937-32203-1-git-send-email-quic_sriva...@quicinc.com> References: <1647965937-32203-1-git-send-email-quic_sriva...@quicinc.com> TO: Srinivasa Rao Mandadapu <quic_sriva...@quicinc.com> TO: agr...@kernel.org TO: bjorn.anders...@linaro.org TO: lgirdw...@gmail.com TO: broo...@kernel.org TO: robh...@kernel.org TO: quic_p...@quicinc.com TO: bgosw...@codeaurora.org TO: pe...@perex.cz TO: ti...@suse.com TO: srinivas.kandaga...@linaro.org TO: rohi...@codeaurora.org TO: linux-arm-...@vger.kernel.org TO: alsa-de...@alsa-project.org TO: devicet...@vger.kernel.org TO: linux-ker...@vger.kernel.org TO: swb...@chromium.org TO: judyhs...@chromium.org CC: Srinivasa Rao Mandadapu <quic_sriva...@quicinc.com> CC: Venkata Prasad Potturu <quic_pott...@quicinc.com>
Hi Srinivasa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on next-20220322] [cannot apply to v5.17] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/ASoC-codecs-Fix-error-handling-in-power-domain-init-and-exit-handlers/20220323-001954 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago config: i386-randconfig-m021-20220321 (https://download.01.org/0day-ci/archive/20220323/202203231218.xywusskw-...@intel.com/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> New smatch warnings: sound/soc/codecs/lpass-macro-common.c:28 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR' Old smatch warnings: sound/soc/codecs/lpass-macro-common.c:38 lpass_macro_pds_init() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +28 sound/soc/codecs/lpass-macro-common.c 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 13 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 14 struct lpass_macro *lpass_macro_pds_init(struct device *dev) 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 15 { 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 16 struct lpass_macro *l_pds; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 17 int ret; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 18 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 19 if (!of_find_property(dev->of_node, "power-domains", NULL)) 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 20 return NULL; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 21 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 22 l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 23 if (!l_pds) 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 24 return ERR_PTR(-ENOMEM); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 25 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 26 l_pds->macro_pd = dev_pm_domain_attach_by_name(dev, "macro"); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 27 if (IS_ERR_OR_NULL(l_pds->macro_pd)) { 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 @28 ret = PTR_ERR(l_pds->macro_pd); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 29 goto macro_err; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 30 } 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 31 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 32 ret = pm_runtime_resume_and_get(l_pds->macro_pd); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 33 if (ret < 0) 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 34 goto macro_sync_err; 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 35 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 36 l_pds->dcodec_pd = dev_pm_domain_attach_by_name(dev, "dcodec"); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 37 if (IS_ERR_OR_NULL(l_pds->dcodec_pd)) { 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 38 ret = PTR_ERR(l_pds->dcodec_pd); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 39 goto dcodec_err; 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 40 } 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 41 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 42 ret = pm_runtime_resume_and_get(l_pds->dcodec_pd); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 43 if (ret < 0) 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 44 goto dcodec_sync_err; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 45 return l_pds; 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 46 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 47 dcodec_sync_err: 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 48 dev_pm_domain_detach(l_pds->dcodec_pd, false); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 49 dcodec_err: 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 50 pm_runtime_put(l_pds->macro_pd); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 51 macro_sync_err: 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 52 dev_pm_domain_detach(l_pds->macro_pd, false); 3761a4daab359c Srinivasa Rao Mandadapu 2022-03-22 53 macro_err: 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 54 return ERR_PTR(ret); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 55 } 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 56 EXPORT_SYMBOL_GPL(lpass_macro_pds_init); 9e3d83c52844f9 Srinivasa Rao Mandadapu 2022-02-26 57 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
