CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: "GNU/Weeb Mailing List" <g...@vger.gnuweeb.org>
CC: linux-ker...@vger.kernel.org
TO: Carl Huang <quic_cjhu...@quicinc.com>
CC: Kalle Valo <quic_kv...@quicinc.com>

tree:   https://github.com/ammarfaizi2/linux-block kvalo/ath/ath-qca
head:   a1b8f857c3eb81c4d54c94682ae7f2c899ed91e3
commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [110/168] ath11k: purge rx 
pktlog when entering WoW
:::::: branch date: 2 hours ago
:::::: commit date: 3 weeks ago
config: ia64-randconfig-c003-20220405 
(https://download.01.org/0day-ci/archive/20220406/202204061857.nsh5gmm5-...@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>
Reported-by: Julia Lawall <julia.law...@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/net/wireless/ath/ath11k/wow.c:672:2-8: preceding lock on line 658

vim +672 drivers/net/wireless/ath/ath11k/wow.c

ba9177fcef21fa9 Carl Huang 2022-03-14  652  
ba9177fcef21fa9 Carl Huang 2022-03-14  653  int ath11k_wow_op_resume(struct 
ieee80211_hw *hw)
ba9177fcef21fa9 Carl Huang 2022-03-14  654  {
ba9177fcef21fa9 Carl Huang 2022-03-14  655      struct ath11k *ar = hw->priv;
ba9177fcef21fa9 Carl Huang 2022-03-14  656      int ret;
ba9177fcef21fa9 Carl Huang 2022-03-14  657  
ba9177fcef21fa9 Carl Huang 2022-03-14 @658      mutex_lock(&ar->conf_mutex);
ba9177fcef21fa9 Carl Huang 2022-03-14  659  
ba9177fcef21fa9 Carl Huang 2022-03-14  660      ret = ath11k_hif_resume(ar->ab);
ba9177fcef21fa9 Carl Huang 2022-03-14  661      if (ret) {
ba9177fcef21fa9 Carl Huang 2022-03-14  662              ath11k_warn(ar->ab, 
"failed to resume hif: %d\n", ret);
ba9177fcef21fa9 Carl Huang 2022-03-14  663              goto exit;
ba9177fcef21fa9 Carl Huang 2022-03-14  664      }
ba9177fcef21fa9 Carl Huang 2022-03-14  665  
ba9177fcef21fa9 Carl Huang 2022-03-14  666      
ath11k_hif_ce_irq_enable(ar->ab);
ba9177fcef21fa9 Carl Huang 2022-03-14  667      ath11k_hif_irq_enable(ar->ab);
ba9177fcef21fa9 Carl Huang 2022-03-14  668  
90bf5c8d0f7ecdd Carl Huang 2022-03-14  669      ret = 
ath11k_dp_rx_pktlog_start(ar->ab);
90bf5c8d0f7ecdd Carl Huang 2022-03-14  670      if (ret) {
90bf5c8d0f7ecdd Carl Huang 2022-03-14  671              ath11k_warn(ar->ab, 
"failed to start rx pktlog from wow: %d\n", ret);
90bf5c8d0f7ecdd Carl Huang 2022-03-14 @672              return ret;
90bf5c8d0f7ecdd Carl Huang 2022-03-14  673      }
90bf5c8d0f7ecdd Carl Huang 2022-03-14  674  
ba9177fcef21fa9 Carl Huang 2022-03-14  675      ret = ath11k_wow_wakeup(ar->ab);
fec4b898f369a9b Carl Huang 2022-03-14  676      if (ret) {
ba9177fcef21fa9 Carl Huang 2022-03-14  677              ath11k_warn(ar->ab, 
"failed to wakeup from wow: %d\n", ret);
fec4b898f369a9b Carl Huang 2022-03-14  678              goto exit;
fec4b898f369a9b Carl Huang 2022-03-14  679      }
fec4b898f369a9b Carl Huang 2022-03-14  680  
fec4b898f369a9b Carl Huang 2022-03-14  681      ret = 
ath11k_wow_nlo_cleanup(ar);
fec4b898f369a9b Carl Huang 2022-03-14  682      if (ret) {
fec4b898f369a9b Carl Huang 2022-03-14  683              ath11k_warn(ar->ab, 
"failed to cleanup nlo: %d\n", ret);
fec4b898f369a9b Carl Huang 2022-03-14  684              goto exit;
fec4b898f369a9b Carl Huang 2022-03-14  685      }
ba9177fcef21fa9 Carl Huang 2022-03-14  686  
c417b247ba04216 Carl Huang 2022-03-14  687      ret = 
ath11k_wow_clear_hw_filter(ar);
c417b247ba04216 Carl Huang 2022-03-14  688      if (ret) {
c417b247ba04216 Carl Huang 2022-03-14  689              ath11k_warn(ar->ab, 
"failed to clear hw filter: %d\n", ret);
c417b247ba04216 Carl Huang 2022-03-14  690              goto exit;
c417b247ba04216 Carl Huang 2022-03-14  691      }
c417b247ba04216 Carl Huang 2022-03-14  692  
ba9177fcef21fa9 Carl Huang 2022-03-14  693  exit:
ba9177fcef21fa9 Carl Huang 2022-03-14  694      if (ret) {
ba9177fcef21fa9 Carl Huang 2022-03-14  695              switch (ar->state) {
ba9177fcef21fa9 Carl Huang 2022-03-14  696              case ATH11K_STATE_ON:
ba9177fcef21fa9 Carl Huang 2022-03-14  697                      ar->state = 
ATH11K_STATE_RESTARTING;
ba9177fcef21fa9 Carl Huang 2022-03-14  698                      ret = 1;
ba9177fcef21fa9 Carl Huang 2022-03-14  699                      break;
ba9177fcef21fa9 Carl Huang 2022-03-14  700              case ATH11K_STATE_OFF:
ba9177fcef21fa9 Carl Huang 2022-03-14  701              case 
ATH11K_STATE_RESTARTING:
ba9177fcef21fa9 Carl Huang 2022-03-14  702              case 
ATH11K_STATE_RESTARTED:
ba9177fcef21fa9 Carl Huang 2022-03-14  703              case 
ATH11K_STATE_WEDGED:
ba9177fcef21fa9 Carl Huang 2022-03-14  704                      
ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot 
recover\n",
ba9177fcef21fa9 Carl Huang 2022-03-14  705                                  
ar->state);
ba9177fcef21fa9 Carl Huang 2022-03-14  706                      ret = -EIO;
ba9177fcef21fa9 Carl Huang 2022-03-14  707                      break;
ba9177fcef21fa9 Carl Huang 2022-03-14  708              }
ba9177fcef21fa9 Carl Huang 2022-03-14  709      }
ba9177fcef21fa9 Carl Huang 2022-03-14  710  
ba9177fcef21fa9 Carl Huang 2022-03-14  711      mutex_unlock(&ar->conf_mutex);
ba9177fcef21fa9 Carl Huang 2022-03-14  712      return ret;
ba9177fcef21fa9 Carl Huang 2022-03-14  713  }
ba9177fcef21fa9 Carl Huang 2022-03-14  714  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

Reply via email to