CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: Linux Memory Management List <linux...@kvack.org> TO: Damien Le Moal <damien.lem...@opensource.wdc.com> CC: Jens Axboe <ax...@kernel.dk> CC: Johannes Thumshirn <johannes.thumsh...@wdc.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 38a288f5941ef03752887ad86f2d85442358c99a commit: 49c3b9266a718dbd73c42e004288b4bb2ea0ac0b [8715/9759] block: null_blk: Improve device creation with configfs :::::: branch date: 10 hours ago :::::: commit date: 2 days ago compiler: riscv32-linux-gcc (GCC) 11.3.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 49c3b9266a718dbd73c42e004288b4bb2ea0ac0b cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) drivers/block/null_blk/main.c:1911:26: warning: The statement 'if (dev->submit_queues!=nr_online_nodes) dev->submit_queues=nr_online_nodes' is logically equivalent to 'dev->submit_queues=nr_online_nodes'. [duplicateConditionalAssign] if (dev->submit_queues != nr_online_nodes) ^ drivers/block/null_blk/main.c:1912:23: note: Assignment 'dev->submit_queues=nr_online_nodes' dev->submit_queues = nr_online_nodes; ^ drivers/block/null_blk/main.c:1911:26: note: Condition 'dev->submit_queues!=nr_online_nodes' is redundant if (dev->submit_queues != nr_online_nodes) ^ >> drivers/block/null_blk/main.c:2111:12: warning: Uninitialized variables: >> nb.dev, nb.list, nb.index, nb.q, nb.disk, nb.tag_set, nb.__tag_set, >> nb.queue_depth, nb.cur_bytes, nb.bw_timer, nb.cache_flush_pos, nb.lock, >> nb.queues, nb.nr_queues [uninitvar] nullb = nb; ^ vim +2111 drivers/block/null_blk/main.c f2298c0403b0df drivers/block/null_blk.c Jens Axboe 2013-10-25 2103 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2104 static struct nullb *null_find_dev_by_name(const char *name) 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2105 { 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2106 struct nullb *nullb = NULL, *nb; 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2107 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2108 mutex_lock(&lock); 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2109 list_for_each_entry(nb, &nullb_list, list) { 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2110 if (strcmp(nb->disk_name, name) == 0) { 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 @2111 nullb = nb; 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2112 break; 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2113 } 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2114 } 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2115 mutex_unlock(&lock); 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2116 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2117 return nullb; 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2118 } 49c3b9266a718d drivers/block/null_blk/main.c Damien Le Moal 2022-04-20 2119 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
