CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Benoit Parrot <bpar...@ti.com>
CC: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
CC: Neil Armstrong <narmstr...@baylibre.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   30c8e80f79329617012f07b09b70114592092ea4
commit: c8fa1e733c597a7b11a22a3e49de5ea1362e9a7a drm/omap: introduce 
omap_hw_overlay
date:   5 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 5 months ago
config: arm-randconfig-m031-20220427 
(https://download.01.org/0day-ci/archive/20220508/202205081844.wxuphtrc-...@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>

smatch warnings:
drivers/gpu/drm/omapdrm/omap_overlay.c:61 omap_hwoverlays_init() warn: passing 
a valid pointer to 'PTR_ERR'

vim +/PTR_ERR +61 drivers/gpu/drm/omapdrm/omap_overlay.c

c8fa1e733c597a Benoit Parrot 2021-11-17  44  
c8fa1e733c597a Benoit Parrot 2021-11-17  45  int omap_hwoverlays_init(struct 
omap_drm_private *priv)
c8fa1e733c597a Benoit Parrot 2021-11-17  46  {
c8fa1e733c597a Benoit Parrot 2021-11-17  47     static const enum omap_plane_id 
hw_plane_ids[] = {
c8fa1e733c597a Benoit Parrot 2021-11-17  48                     OMAP_DSS_GFX, 
OMAP_DSS_VIDEO1,
c8fa1e733c597a Benoit Parrot 2021-11-17  49                     
OMAP_DSS_VIDEO2, OMAP_DSS_VIDEO3,
c8fa1e733c597a Benoit Parrot 2021-11-17  50     };
c8fa1e733c597a Benoit Parrot 2021-11-17  51     u32 num_overlays = 
dispc_get_num_ovls(priv->dispc);
c8fa1e733c597a Benoit Parrot 2021-11-17  52     enum omap_overlay_caps caps;
c8fa1e733c597a Benoit Parrot 2021-11-17  53     int i, ret;
c8fa1e733c597a Benoit Parrot 2021-11-17  54  
c8fa1e733c597a Benoit Parrot 2021-11-17  55     for (i = 0; i < num_overlays; 
i++) {
c8fa1e733c597a Benoit Parrot 2021-11-17  56             struct omap_hw_overlay 
*overlay;
c8fa1e733c597a Benoit Parrot 2021-11-17  57  
c8fa1e733c597a Benoit Parrot 2021-11-17  58             caps = 
dispc_ovl_get_caps(priv->dispc, hw_plane_ids[i]);
c8fa1e733c597a Benoit Parrot 2021-11-17  59             overlay = 
omap_overlay_init(hw_plane_ids[i], caps);
c8fa1e733c597a Benoit Parrot 2021-11-17  60             if (IS_ERR(overlay)) {
c8fa1e733c597a Benoit Parrot 2021-11-17 @61                     ret = 
PTR_ERR(overlay);
c8fa1e733c597a Benoit Parrot 2021-11-17  62                     
dev_err(priv->dev, "failed to construct overlay for %s (%d)\n",
c8fa1e733c597a Benoit Parrot 2021-11-17  63                             
overlay_id_to_name[i], ret);
c8fa1e733c597a Benoit Parrot 2021-11-17  64                     
omap_hwoverlays_destroy(priv);
c8fa1e733c597a Benoit Parrot 2021-11-17  65                     return ret;
c8fa1e733c597a Benoit Parrot 2021-11-17  66             }
c8fa1e733c597a Benoit Parrot 2021-11-17  67             overlay->idx = 
priv->num_ovls;
c8fa1e733c597a Benoit Parrot 2021-11-17  68             
priv->overlays[priv->num_ovls++] = overlay;
c8fa1e733c597a Benoit Parrot 2021-11-17  69     }
c8fa1e733c597a Benoit Parrot 2021-11-17  70  
c8fa1e733c597a Benoit Parrot 2021-11-17  71     return 0;
c8fa1e733c597a Benoit Parrot 2021-11-17  72  }
c8fa1e733c597a Benoit Parrot 2021-11-17  73  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

Reply via email to