:::::: :::::: Manual check reason: "low confidence static check first_new_problem: drivers/net/can/rcar/rcar_can.c:812:6: warning: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]" ::::::
CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: linux-ker...@vger.kernel.org TO: Cai Huoqing <caihuoq...@baidu.com> CC: "Marc Kleine-Budde" <m...@pengutronix.de> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6e7765cb477a9753670d4351d14de93f1e9dbbd4 commit: ac4224087312d7212bd3411f1e393f4b7cb1ff15 can: rcar: Kconfig: Add helper dependency on COMPILE_TEST date: 11 months ago :::::: branch date: 19 hours ago :::::: commit date: 11 months ago compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout ac4224087312d7212bd3411f1e393f4b7cb1ff15 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <l...@intel.com> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/net/can/rcar/rcar_can.c:812:6: warning: Redundant initialization for >> 'err'. The initialized value is overwritten before it is read. >> [redundantInitialization] err = register_candev(ndev); ^ drivers/net/can/rcar/rcar_can.c:749:10: note: err is initialized int err = -ENODEV; ^ drivers/net/can/rcar/rcar_can.c:812:6: note: err is overwritten err = register_candev(ndev); ^ >> drivers/net/can/rcar/rcar_can.c:480:9: warning: Shifting signed 32-bit value >> by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] writel(RCAR_CAN_FIDCR_IDE | RCAR_CAN_FIDCR_RTR, &priv->regs->fidcr[1]); ^ drivers/net/can/rcar/rcar_can.c:603:40: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] data = (cf->can_id & CAN_EFF_MASK) | RCAR_CAN_IDE; ^ drivers/net/can/rcar/rcar_can.c:656:13: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] if (data & RCAR_CAN_IDE) ^ >> drivers/net/can/rcar/rcar_can.c:480:9: warning: Signed integer overflow for >> expression '1<<31'. [integerOverflow] writel(RCAR_CAN_FIDCR_IDE | RCAR_CAN_FIDCR_RTR, &priv->regs->fidcr[1]); ^ drivers/net/can/rcar/rcar_can.c:603:40: warning: Signed integer overflow for expression '1<<31'. [integerOverflow] data = (cf->can_id & CAN_EFF_MASK) | RCAR_CAN_IDE; ^ drivers/net/can/rcar/rcar_can.c:656:13: warning: Signed integer overflow for expression '1<<31'. [integerOverflow] if (data & RCAR_CAN_IDE) ^ vim +/err +812 drivers/net/can/rcar/rcar_can.c 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 742 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 743 static int rcar_can_probe(struct platform_device *pdev) fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 744 { fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 745 struct rcar_can_priv *priv; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 746 struct net_device *ndev; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 747 void __iomem *addr; a268de6c68e493 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 748 u32 clock_select = CLKR_CLKP1; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 749 int err = -ENODEV; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 750 int irq; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 751 30cc0ed73e3390 drivers/net/can/rcar/rcar_can.c Geert Uytterhoeven 2019-08-14 752 of_property_read_u32(pdev->dev.of_node, "renesas,can-clock-select", 30cc0ed73e3390 drivers/net/can/rcar/rcar_can.c Geert Uytterhoeven 2019-08-14 753 &clock_select); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 754 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 755 irq = platform_get_irq(pdev, 0); 5e63e6baa159fa drivers/net/can/rcar_can.c Sergei Shtylyov 2015-06-20 756 if (irq < 0) { 5e63e6baa159fa drivers/net/can/rcar_can.c Sergei Shtylyov 2015-06-20 757 err = irq; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 758 goto fail; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 759 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 760 ac9921ded292bf drivers/net/can/rcar/rcar_can.c YueHaibing 2019-10-15 761 addr = devm_platform_ioremap_resource(pdev, 0); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 762 if (IS_ERR(addr)) { fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 763 err = PTR_ERR(addr); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 764 goto fail; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 765 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 766 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 767 ndev = alloc_candev(sizeof(struct rcar_can_priv), RCAR_CAN_FIFO_DEPTH); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 768 if (!ndev) { fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 769 dev_err(&pdev->dev, "alloc_candev() failed\n"); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 770 err = -ENOMEM; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 771 goto fail; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 772 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 773 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 774 priv = netdev_priv(ndev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 775 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 776 priv->clk = devm_clk_get(&pdev->dev, "clkp1"); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 777 if (IS_ERR(priv->clk)) { fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 778 err = PTR_ERR(priv->clk); 585bc2ac4cc0e2 drivers/net/can/rcar_can.c Sergei Shtylyov 2015-06-20 779 dev_err(&pdev->dev, "cannot get peripheral clock, error %d\n", 585bc2ac4cc0e2 drivers/net/can/rcar_can.c Sergei Shtylyov 2015-06-20 780 err); 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 781 goto fail_clk; 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 782 } 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 783 68c8d209cd4337 drivers/net/can/rcar/rcar_can.c Fabrizio Castro 2018-09-10 784 if (!(BIT(clock_select) & RCAR_SUPPORTED_CLOCKS)) { 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 785 err = -EINVAL; 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 786 dev_err(&pdev->dev, "invalid CAN clock selected\n"); 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 787 goto fail_clk; 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 788 } 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 789 priv->can_clk = devm_clk_get(&pdev->dev, clock_names[clock_select]); 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 790 if (IS_ERR(priv->can_clk)) { 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 791 err = PTR_ERR(priv->can_clk); 585bc2ac4cc0e2 drivers/net/can/rcar_can.c Sergei Shtylyov 2015-06-20 792 dev_err(&pdev->dev, "cannot get CAN clock, error %d\n", err); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 793 goto fail_clk; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 794 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 795 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 796 ndev->netdev_ops = &rcar_can_netdev_ops; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 797 ndev->irq = irq; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 798 ndev->flags |= IFF_ECHO; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 799 priv->ndev = ndev; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 800 priv->regs = addr; 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 801 priv->clock_select = clock_select; 862e2b6af9413b drivers/net/can/rcar_can.c Sergei Shtylyov 2014-08-01 802 priv->can.clock.freq = clk_get_rate(priv->can_clk); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 803 priv->can.bittiming_const = &rcar_can_bittiming_const; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 804 priv->can.do_set_mode = rcar_can_do_set_mode; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 805 priv->can.do_get_berr_counter = rcar_can_get_berr_counter; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 806 priv->can.ctrlmode_supported = CAN_CTRLMODE_BERR_REPORTING; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 807 platform_set_drvdata(pdev, ndev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 808 SET_NETDEV_DEV(ndev, &pdev->dev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 809 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 810 netif_napi_add(ndev, &priv->napi, rcar_can_rx_poll, fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 811 RCAR_CAN_NAPI_WEIGHT); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 @812 err = register_candev(ndev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 813 if (err) { fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 814 dev_err(&pdev->dev, "register_candev() failed, error %d\n", fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 815 err); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 816 goto fail_candev; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 817 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 818 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 819 devm_can_led_init(ndev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 820 ca257b9e2d807a drivers/net/can/rcar/rcar_can.c Geert Uytterhoeven 2017-04-03 821 dev_info(&pdev->dev, "device registered (IRQ%d)\n", ndev->irq); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 822 fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 823 return 0; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 824 fail_candev: fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 825 netif_napi_del(&priv->napi); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 826 fail_clk: fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 827 free_candev(ndev); fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 828 fail: fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 829 return err; fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 830 } fd1159318e55e9 drivers/net/can/rcar_can.c Sergei Shtylyov 2014-05-17 831 :::::: The code at line 812 was first introduced by commit :::::: fd1159318e55e901cf269de90163b19fd62938cb can: add Renesas R-Car CAN driver :::::: TO: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> :::::: CC: Marc Kleine-Budde <m...@pengutronix.de> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
