BCC: l...@intel.com CC: kbuild-...@lists.01.org CC: linux-ker...@vger.kernel.org TO: Lucas Tanure <tanur...@opensource.cirrus.com> CC: Takashi Iwai <ti...@suse.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d4252071b97d2027d246f6a82cbee4d52f618b47 commit: a025df02ce424fa77f6bc6aa195db21677e11274 ALSA: hda: cs35l41: Make use of the helper function dev_err_probe() date: 7 months ago :::::: branch date: 16 hours ago :::::: commit date: 7 months ago config: i386-randconfig-m021-20220808 (https://download.01.org/0day-ci/archive/20220810/202208102251.c4dhtawh-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: sound/pci/hda/cs35l41_hda.c:433 cs35l41_hda_probe() warn: missing error code 'ret' vim +/ret +433 sound/pci/hda/cs35l41_hda.c 7b2f3eb492dac7 Lucas Tanure 2021-12-17 401 7b2f3eb492dac7 Lucas Tanure 2021-12-17 402 int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int irq, 7b2f3eb492dac7 Lucas Tanure 2021-12-17 403 struct regmap *regmap) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 404 { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 405 unsigned int int_sts, regid, reg_revid, mtl_revid, chipid, int_status; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 406 struct cs35l41_hda_hw_config *acpi_hw_cfg; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 407 struct cs35l41_hda *cs35l41; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 408 int ret; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 409 7b2f3eb492dac7 Lucas Tanure 2021-12-17 410 if (IS_ERR(regmap)) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 411 return PTR_ERR(regmap); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 412 7b2f3eb492dac7 Lucas Tanure 2021-12-17 413 cs35l41 = devm_kzalloc(dev, sizeof(*cs35l41), GFP_KERNEL); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 414 if (!cs35l41) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 415 return -ENOMEM; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 416 7b2f3eb492dac7 Lucas Tanure 2021-12-17 417 cs35l41->dev = dev; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 418 cs35l41->irq = irq; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 419 cs35l41->regmap = regmap; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 420 dev_set_drvdata(dev, cs35l41); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 421 7b2f3eb492dac7 Lucas Tanure 2021-12-17 422 acpi_hw_cfg = cs35l41_hda_read_acpi(cs35l41, device_name, id); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 423 if (IS_ERR(acpi_hw_cfg)) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 424 return PTR_ERR(acpi_hw_cfg); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 425 7b2f3eb492dac7 Lucas Tanure 2021-12-17 426 if (IS_ERR(cs35l41->reset_gpio)) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 427 ret = PTR_ERR(cs35l41->reset_gpio); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 428 cs35l41->reset_gpio = NULL; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 429 if (ret == -EBUSY) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 430 dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n"); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 431 } else { a025df02ce424f Lucas Tanure 2022-01-17 432 dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 @433 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 434 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 435 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 436 if (cs35l41->reset_gpio) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 437 usleep_range(2000, 2100); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 438 gpiod_set_value_cansleep(cs35l41->reset_gpio, 1); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 439 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 440 7b2f3eb492dac7 Lucas Tanure 2021-12-17 441 usleep_range(2000, 2100); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 442 7b2f3eb492dac7 Lucas Tanure 2021-12-17 443 ret = regmap_read_poll_timeout(cs35l41->regmap, CS35L41_IRQ1_STATUS4, int_status, 7b2f3eb492dac7 Lucas Tanure 2021-12-17 444 int_status & CS35L41_OTP_BOOT_DONE, 1000, 100000); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 445 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 446 dev_err(cs35l41->dev, "Failed waiting for OTP_BOOT_DONE: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 447 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 448 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 449 7b2f3eb492dac7 Lucas Tanure 2021-12-17 450 ret = regmap_read(cs35l41->regmap, CS35L41_IRQ1_STATUS3, &int_sts); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 451 if (ret || (int_sts & CS35L41_OTP_BOOT_ERR)) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 452 dev_err(cs35l41->dev, "OTP Boot error\n"); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 453 ret = -EIO; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 454 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 455 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 456 7b2f3eb492dac7 Lucas Tanure 2021-12-17 457 ret = regmap_read(cs35l41->regmap, CS35L41_DEVID, ®id); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 458 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 459 dev_err(cs35l41->dev, "Get Device ID failed: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 460 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 461 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 462 7b2f3eb492dac7 Lucas Tanure 2021-12-17 463 ret = regmap_read(cs35l41->regmap, CS35L41_REVID, ®_revid); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 464 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 465 dev_err(cs35l41->dev, "Get Revision ID failed: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 466 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 467 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 468 7b2f3eb492dac7 Lucas Tanure 2021-12-17 469 mtl_revid = reg_revid & CS35L41_MTLREVID_MASK; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 470 7b2f3eb492dac7 Lucas Tanure 2021-12-17 471 chipid = (mtl_revid % 2) ? CS35L41R_CHIP_ID : CS35L41_CHIP_ID; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 472 if (regid != chipid) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 473 dev_err(cs35l41->dev, "CS35L41 Device ID (%X). Expected ID %X\n", regid, chipid); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 474 ret = -ENODEV; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 475 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 476 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 477 6e4320d8ecbc87 Charles Keepax 2022-01-17 478 ret = cs35l41_test_key_unlock(cs35l41->dev, cs35l41->regmap); 6e4320d8ecbc87 Charles Keepax 2022-01-17 479 if (ret) 6e4320d8ecbc87 Charles Keepax 2022-01-17 480 goto err; 6e4320d8ecbc87 Charles Keepax 2022-01-17 481 7b2f3eb492dac7 Lucas Tanure 2021-12-17 482 ret = cs35l41_register_errata_patch(cs35l41->dev, cs35l41->regmap, reg_revid); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 483 if (ret) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 484 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 485 7b2f3eb492dac7 Lucas Tanure 2021-12-17 486 ret = cs35l41_otp_unpack(cs35l41->dev, cs35l41->regmap); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 487 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 488 dev_err(cs35l41->dev, "OTP Unpack failed: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 489 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 490 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 491 6e4320d8ecbc87 Charles Keepax 2022-01-17 492 ret = cs35l41_test_key_lock(cs35l41->dev, cs35l41->regmap); 6e4320d8ecbc87 Charles Keepax 2022-01-17 493 if (ret) 6e4320d8ecbc87 Charles Keepax 2022-01-17 494 goto err; 6e4320d8ecbc87 Charles Keepax 2022-01-17 495 7b2f3eb492dac7 Lucas Tanure 2021-12-17 496 ret = cs35l41_hda_apply_properties(cs35l41, acpi_hw_cfg); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 497 if (ret) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 498 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 499 kfree(acpi_hw_cfg); 10b1a5a99c6ac4 Dan Carpenter 2022-01-11 500 acpi_hw_cfg = NULL; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 501 7b2f3eb492dac7 Lucas Tanure 2021-12-17 502 if (cs35l41->reg_seq->probe) { 2cb52046d18686 Charles Keepax 2022-01-17 503 ret = regmap_multi_reg_write(cs35l41->regmap, cs35l41->reg_seq->probe, 7b2f3eb492dac7 Lucas Tanure 2021-12-17 504 cs35l41->reg_seq->num_probe); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 505 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 506 dev_err(cs35l41->dev, "Fail to apply probe reg patch: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 507 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 508 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 509 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 510 7b2f3eb492dac7 Lucas Tanure 2021-12-17 511 ret = component_add(cs35l41->dev, &cs35l41_hda_comp_ops); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 512 if (ret) { 7b2f3eb492dac7 Lucas Tanure 2021-12-17 513 dev_err(cs35l41->dev, "Register component failed: %d\n", ret); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 514 goto err; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 515 } 7b2f3eb492dac7 Lucas Tanure 2021-12-17 516 7b2f3eb492dac7 Lucas Tanure 2021-12-17 517 dev_info(cs35l41->dev, "Cirrus Logic CS35L41 (%x), Revision: %02X\n", regid, reg_revid); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 518 7b2f3eb492dac7 Lucas Tanure 2021-12-17 519 return 0; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 520 7b2f3eb492dac7 Lucas Tanure 2021-12-17 521 err: 7b2f3eb492dac7 Lucas Tanure 2021-12-17 522 kfree(acpi_hw_cfg); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 523 if (!cs35l41->vspk_always_on) 7b2f3eb492dac7 Lucas Tanure 2021-12-17 524 gpiod_set_value_cansleep(cs35l41->reset_gpio, 0); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 525 gpiod_put(cs35l41->reset_gpio); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 526 7b2f3eb492dac7 Lucas Tanure 2021-12-17 527 return ret; 7b2f3eb492dac7 Lucas Tanure 2021-12-17 528 } 77dc3a6ee2eb58 Lucas Tanure 2022-01-17 529 EXPORT_SYMBOL_NS_GPL(cs35l41_hda_probe, SND_HDA_SCODEC_CS35L41); 7b2f3eb492dac7 Lucas Tanure 2021-12-17 530 :::::: The code at line 433 was first introduced by commit :::::: 7b2f3eb492dac7665c75df067e4d8e4869589f4a ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems :::::: TO: Lucas Tanure <tanur...@opensource.cirrus.com> :::::: CC: Takashi Iwai <ti...@suse.de> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
