On Wed, 12 Jun 2002 11:35:42 +0200 (DFT), 
LELARGE Sebastien <[EMAIL PROTECTED]> wrote:
>I'm student in France and for now I'm working on IA64 machines by BULL 
>in France. We had a problem using KDB on Tiger machine because of the
>lack of PS/2 port on this machine. In order to bring a solution, I
>have written some code to bring USB support in KDB. I'm using a RedHat 
>7.2. You must apply this patch after the 2 KDB patches. It provides an 
>option called "Support for USB Keyboard in KDB" in section Kernel
>Hacking. 

Thanks for the patch, it has been uploaded as
ftp://oss.sgi.com/projects/kdb/download/v2.1/kdb-v2.1-2.4.18-ia64-usb-keyboard-1.bz2.

A couple of comments:

Could you use the same coding standard as the rest of the kernel and
usb code?  It makes the patch look cleaner.  Running your changes
through scripts/Lindent is the easiest way to standardize the code.

You test jiffies, looking for a timeout.  When kdb is in control all
interrupts are disabled, including the timer.  jiffies should not be
changing at all.

Reply via email to