https://bugs.kde.org/show_bug.cgi?id=484789

Carl Schwan <c...@carlschwan.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/-/commit/b425985
                   |                            |c9c5845d304a4461929656bbd93
                   |                            |7c3a01

--- Comment #6 from Carl Schwan <c...@carlschwan.eu> ---
Git commit b425985c9c5845d304a4461929656bbd937c3a01 by Carl Schwan, on behalf
of Thomas Duckworth.
Committed on 05/10/2024 at 22:51.
Pushed by carlschwan into branch 'master'.

Clean up Properties dialog to follow HIG, improve UX, remove frames and fix
padding regression

Plasma 6 introduced a regression in this dialog where there are no longer
proper margins in most tabs, due to the move to a frameless style. This makes
specifically URL and Application properties tabs look quite bad, as they end up
with text glyphs right up against the edge of the window. Explicit 0px margins
are removed, instead leaving the layouts to inherit from the stylesheet, which
also improves maintainability.

The dialog can no longer be shrunk to the point where the tab contents look
broken.

In the Permissions pane, the QGroupBox is now flat, so it looks the same as
Kirigami.FormLayout, and doesn't have unnecessary frames. It's also ported to
QFormLayout.

QLabel in KChecksumsPlugin is now a readonly QLineEdit, as this shows a nice
looking box, and doesn't unexpectedly expand the window by an insane amount,
where it can't be resized back down to a normal size.

M  +4    -4    src/widgets/checksumswidget.ui
M  +1    -0    src/widgets/kacleditwidget.cpp
M  +0    -12   src/widgets/kpropertiesdesktopadvbase.ui
M  +0    -3    src/widgets/kpropertiesdesktopbase.ui
M  +3    -0    src/widgets/kpropertiesdialog.cpp
M  +59   -55   src/widgets/kpropertiesdialogbuiltin_p.cpp
M  +2    -2    src/widgets/kpropertiesdialogbuiltin_p.h

https://invent.kde.org/frameworks/kio/-/commit/b425985c9c5845d304a4461929656bbd937c3a01

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to