https://bugs.kde.org/show_bug.cgi?id=496581
Tuomas Nurmi <tuo...@norsumanageri.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/mult
| |imedia/amarok/-/commit/e536
| |3c31ee9ecf1ecc7cb87b59e69f6
| |9e188d9b4
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Tuomas Nurmi <tuo...@norsumanageri.org> ---
Git commit e5363c31ee9ecf1ecc7cb87b59e69f69e188d9b4 by Tuomas Nurmi, on behalf
of Ian Abbott.
Committed on 04/12/2024 at 21:18.
Pushed by nurmi into branch 'master'.
Update Ampache server version check
The value of the `<value>` element in the response from a ping request
to the Ampache server changed from a six-digit integer to a dotted
triple in Ampache version 5.0.0. This screws up the check for whether
to use the new style of authentication string based on a SHA256 hash, or
the old (now ancient) style of authentication string based on an MD5
hash. It will try and login to Ampache server version 5.0.0 or later
using the old style of authentication string and so fail to login
successfully.
Use the value of the `<compatible>` element instead if it exists,
falling back to the `<version>` element if it doesn't. The
`<compatible>` element was introduced in Ampache 3.5.2 and has the
integer value 350001. This indicates a version older than the actual
version, but it is good enough to determine that the new style of
authentication string should be used.
Also correct the "Version Older than 35001" debug message that has a
missing digit (it should be 350001).
Signed-off-by: Ian Abbott <i...@abbott.org>
M +17 -3 src/services/ampache/AmpacheAccountLogin.cpp
https://invent.kde.org/multimedia/amarok/-/commit/e5363c31ee9ecf1ecc7cb87b59e69f69e188d9b4
--
You are receiving this mail because:
You are watching all bug changes.
