https://bugs.kde.org/show_bug.cgi?id=373702

            Bug ID: 373702
           Summary: The android toolchain doesn't support locally built
                    shared libraries
           Product: extra-cmake-modules
           Version: unspecified
          Platform: Other
                OS: Android 5.x
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: AndroidToolchain
          Assignee: aleix...@kde.org
          Reporter: elv1...@gmail.com
  Target Milestone: ---

When a .so library is added to the project using add_subdirectory, then it
doesn't build for android because the RegEx used to convert the paths strip
relative paths from the point of view of the build directory.

for example, the lib will be "Qt-Color-Widgets/foo.so" will be converted to 
"/foo.so".

diff --git a/toolchain/specifydependencies.cmake
b/toolchain/specifydependencies.cmake
index 65e875b..b2fc83e 100644
--- a/toolchain/specifydependencies.cmake
+++ b/toolchain/specifydependencies.cmake
@@ -2,7 +2,7 @@ file(READ
"${TARGET_DIR}/CMakeFiles/${TARGET_NAME}.dir/link.txt" out)

 string(FIND "${out}" "-o ${TARGET_NAME}" POS) #we trim the initial arguments,
we want the ones in the end. we find the target
 string(SUBSTRING "${out}" ${POS} -1 out) #we
-string(REGEX MATCHALL "(/|\\.\\./|\\./)[^ ]+\\.so" outout "${out}")
+string(REGEX MATCHALL "[^ ]+\\.so" outout "${out}")
 string(STRIP "${outout}" outout)
 string(REPLACE " /" ";/" outout "${outout}")

This patch remove the RegEx first group, as it seems useless and wrong. However
if its there, I guess this it's no accident.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to