https://bugs.kde.org/show_bug.cgi?id=503969

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
This is pretty hard to review without knowing what is intended.

As far as I can see there are a couple changes:
- ORIG_PWD isn't used anymore and is replace by SCRIPT_SRC=$(dirname $0)
  - This makes it possible to invoke the script from anywhere
- LOGDIR is redefined to no longer use the valgrind-ltp-logs but a more generic
tests subdir
  - The buildbot relies on the old name and so should be adjusted to deal with
"tests"
- The summary.log isn't generated anymore
- myLog isn't used anymore and is replaced by echo -e which means
  - That backslash escapes are now handled (no more literal \n in the output)
  - The individual test summary files aren't generated anymore
- Inside the LOGDIR a couple of files are generated:
  - test-suite.log which is kept empty? Was this intended to be the new
summary.log?
  - Various .bunsen* files. Are these necessary when the buildbot does the
bunsen uploading?
- Two automake style testlog files are generated
  - the $exe.log which contains something on FAIL, but is empty on PASS (is
that intended?)
  - a $exe.trs file that contains the PASS or FAIL status.

Please review my understanding and update whether this is expected behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to