https://bugs.kde.org/show_bug.cgi?id=501378

--- Comment #6 from kolAflash <kolafl...@kolahilft.de> ---
There was some confusion in my comment 4.
All the following points are in my kwin-6.3.* patch.

These are the relevant code positions for the bug:
old X11:
https://invent.kde.org/plasma/kwin/-/blob/v5.27.12/src/useractions.cpp?ref_type=tags#L557
new X11:
https://invent.kde.org/plasma/kwin/-/blob/v6.3.90/src/useractions.cpp?ref_type=tags#L488

Wayland seems to never had mnemonics (shortcuts). But it at least had numbers
in kwin-5.27.11.
old Wayland:
https://invent.kde.org/plasma/kwin/-/blob/v5.27.12/src/useractions.cpp?ref_type=tags#L646
new Wayland:
https://invent.kde.org/plasma/kwin/-/blob/v6.3.90/src/useractions.cpp?ref_type=tags#L565
And I think here the "desktop->name()" misses the replacement pattern:
> desktop->name().replace(QLatin1Char('&'), QStringLiteral("&&"))

Another mnemonic is missing here. I suggest: "&Move to New Desktop"
https://invent.kde.org/plasma/kwin/-/blob/v6.3.90/src/useractions.cpp?ref_type=tags#L590

Everything until here has been tested with my patch on Debian-13 with X11 and
Wayland and can probably be merged. Although translation files may need to be
updated.

-

Additionally the new Wayland-only "add to desktop" ("add" vs. classical "move")
option also has no mnemonic yet.
https://invent.kde.org/plasma/kwin/-/blob/v6.3.90/src/useractions.cpp?ref_type=tags#L546
Included a fix for that in my patch too. But I'm not sure if this part should
be merged.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to