https://bugs.kde.org/show_bug.cgi?id=504957
--- Comment #2 from Karl Ove Hufthammer <k...@huftis.org> ---
Or has the ‘open on Ctrl + click’ behaviour always been there, and I’m
confusing it with the ‘Shift + click‘ behaviour (to select a range of files
*without opening them*). Anyway, the automatic switch to open files behaviour
bug seems to have been introduced in this commit:
commit 053fb00b5ec5d26e3e42be5039b2e3e8291a5597
Author: Finley Watson <fi...@tutanota.com>
Date: Mon Feb 24 00:57:28 2025 +0000
Port from QMdiSubWindows
**Visual changes:**
- Tabs no longer stretch to accommodate as much space as possible in the
tab bar.
- The border around the tab pages
(https://invent.kde.org/sdk/lokalize/-/merge_requests/141), between the tab
pages and the main window, is now gone: this is a positive change.
- Tabs have icons, building on the work from !197 and !200
(fd0b044a74be85efc213977187f4832e1ef101b4 and
0bbe7e90029b9bcbfe0b8382bfd7223ddee77c3f).
**Functionality changes:**
- An editor tab containing unsaved changes will use the save icon instead
of the default icon. This functionality is similar to Kate's file tabs.
- When closing an editor tab page that has unsaved changes when the page is
not activated, the page is activated prior to the Save / Cancel popup showing,
so it's clear which document is prompting you to save / discard its changes.
- When there are no open tabs, the welcome screen shows. This is similar to
KWrite's welcome screen. Previously the welcome screen only showed within the
Project Overview tab page, when the user selected "Close project" from the
menu.
**Code changes:**
- All tab pages are now ported from QMdiSubWindows to a common base class
(`LokalizeTabPageBase`) which for now is a KXMLGUIClient / KMainWindow.
- The logic open / close / activate a tab is more explicit and dedicated
methods for these actions exist.
**Preserved functionality:**
- Ctrl+Tab and Ctrl+Shift+Tab cycle between tabs.
- Ctrl+[ toggles between the last two tabs activated.
- Ctrl+W closes a tab.
- Changing active tab page changes the contents of the menu-, tool- and
status bars.
- Only the keyboard shortcuts for the currently active tab page function.
This merge request is step towards a larger fix relating to bug 424024 and
bug 477704 but does not actually fix them.
src/editortab.cpp | 45 +-----
src/editortab.h | 25 ++--
src/filesearch/filesearchtab.cpp | 1 -
src/lokalizemainwindow.cpp | 573
++++++++++++++++++++++++++++++++++++++++++------------------------------
src/lokalizemainwindow.h | 113 ++++++++++-----
src/lokalizesubwindowbase.h | 1 +
src/project/projecttab.cpp | 1 -
src/project/projecttab.h | 1 -
src/tm/tmtab.cpp | 1 -
9 files changed, 432 insertions(+), 329 deletions(-)
--
You are receiving this mail because:
You are watching all bug changes.
