https://bugs.kde.org/show_bug.cgi?id=374310
David Edmundson <k...@davidedmundson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/pla | |sma-desktop/ed73ecd6a3de4be | |92a0630bbeb5815a038706a7d --- Comment #6 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit ed73ecd6a3de4be92a0630bbeb5815a038706a7d by David Edmundson. Committed on 04/01/2017 at 14:09. Pushed by davidedmundson into branch 'master'. Make AppstreamQt optional Summary: Normally I would just close any bug report saying a 3rd party lib should be optional, but it's quite a big dependency chain for a fairly minor feature that is easy to ifdef out. Also we're depending on something that was only released a few weeks ago, in experience that generally will cause some distro to patch it out anyway. Test Plan: My AppstreamQt (from distro packages) is broken, so needed to do a temporary workaround anyway. Built this and it works, haven't been able to test a with appstream version. Reviewers: #plasma, apol Reviewed By: apol Subscribers: anthonyfieroni, huber, hein, mak, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D3923 M +10 -1 CMakeLists.txt M +4 -1 applets/kicker/CMakeLists.txt M +8 -0 applets/kicker/plugin/appentry.cpp A +1 -0 config-appstream.h.cmake https://commits.kde.org/plasma-desktop/ed73ecd6a3de4be92a0630bbeb5815a038706a7d -- You are receiving this mail because: You are watching all bug changes.