https://bugs.kde.org/show_bug.cgi?id=504126

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/kio-extras/-/commit/c92
                   |                            |6156c88b64cd810b232563dd4d2
                   |                            |8841841ef2
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit c926156c88b64cd810b232563dd4d28841841ef2 by Nicolas Fella.
Committed on 13/06/2025 at 10:05.
Pushed by nicolasfella into branch 'master'.

[thumbnail] Don't create a temporary QApplication to determine the
platformtheme name

The current code creates a qapp to query the platform theme name and use that
to
configure the actual qapp.

We do that since we want to use the offscreen platformtheme with our actual
platformtheme
plugin.

However by instantiating the KDEPlatformTheme we trigger KWindowSystem's
platform detection
code, which will cache the platform information (X11 or Wayland). Later we want
that to be
'Unknown' though.

This trips up other code that relies on the KWindowSystem platform check before
doing
windowsystem-specific stuff.

What we really want is a way to obtain the platformtheme name without creating
an actual
instance.

Qt doesn't have API to do that, so copy the bit of code that determines the
platform from
QGenericUnixServices

M  +0    -9    thumbnail/CMakeLists.txt
M  +86   -13   thumbnail/thumbnail.cpp

https://invent.kde.org/network/kio-extras/-/commit/c926156c88b64cd810b232563dd4d28841841ef2

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to